Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why did we prioritize in this case the google without context? #254

Open
mircealungu opened this issue Oct 15, 2024 · 3 comments
Open

why did we prioritize in this case the google without context? #254

mircealungu opened this issue Oct 15, 2024 · 3 comments

Comments

@mircealungu
Copy link
Member

image
@tfnribeiro
Copy link
Collaborator

I thought we always take the Google translation first, not the context?

@mircealungu
Copy link
Member Author

mircealungu commented Oct 17, 2024

hmm. if we care about quality we should prioritize contextual translations.

there's this translator.quality attribute that every translator has and the value for it is higher for the Contextual Google, so if this was used (as I thought that we are doing) then contextual translations should be at the top...

image image

@tfnribeiro
Copy link
Collaborator

I believe I found the reason for this @mircealungu .

    if not MULTI_LANG_TRANSLATOR_AB_TESTING:
        # Disabling order by quality when A/B testing is enabled
        translations = order_by_quality(translations, translator_data["query"])

For some reason, we still have the MULTI_LANG_TRANSLATOR_AB_TESTING is set to '42'.

>>> os.environ.get("MULTI_LANG_TRANSLATOR_AB_TESTING", None)
'42'

So, I believe this is the reason for not showing the context as the first, since it won't order the translations by quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants