Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate over verifySteadyStateCmd #249

Closed
ChrisKujawa opened this issue Nov 22, 2022 · 0 comments · Fixed by #252
Closed

Iterate over verifySteadyStateCmd #249

ChrisKujawa opened this issue Nov 22, 2022 · 0 comments · Fixed by #252
Assignees

Comments

@ChrisKujawa
Copy link
Member

Instead of having zbchaos verify steady-state which does multiple things (deploy a model, create an instance or ONLY create instance for a specific version) we should replace that and use zbchaos deploy and and command to create an instance on a specific partition in order to verify our steady state.

This would mean we rename the subcommand for example to zbchaos verify instance-creation or something else, and remove the deploy logic.

Then everything does exactly one thing and it can easily combined or omitted (deployment). I think it makes the usage clearer.

Also related to @oleschoenburg review comment #246 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant