Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd-. is toggling line comment not ToggleQuickAction #21155

Closed
1 task done
Dracks opened this issue Nov 25, 2024 · 5 comments
Closed
1 task done

cmd-. is toggling line comment not ToggleQuickAction #21155

Dracks opened this issue Nov 25, 2024 · 5 comments
Labels
bug [core label] internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc

Comments

@Dracks
Copy link

Dracks commented Nov 25, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Until some days ago, when pressing the shortcut cmd-. it was opening the quick actions menu (super usefull) which is the same shortcut than in vscode. But now cmd-. is toggling the line comment, and I cannot change this, I tried with the shortcuts configuration of zed and others.

Is super annoying, the default shortcuts configuration say the shortcut is ok. I'm editing typescript files

Environment

Zed: v0.162.5 (Zed)
OS: macOS 15.1.1
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

@Dracks Dracks added admin read bug [core label] labels Nov 25, 2024
@SomeoneToIgnore
Copy link
Contributor

I believe this is related to #20425 but without more data (e.g. keyboard layout) it's not possible to say.

@Dracks
Copy link
Author

Dracks commented Nov 25, 2024

Keyboard layout is Spanish qwerty.

I also saw it, and yes it can be related, but not sure about that.

Anything extra needed, please ask.

@SomeoneToIgnore
Copy link
Contributor

Sorry, I am not in the context of this change, so I'd suggest posting this data into that issue, so @ConradIrwin could notice that case too.

@notpeter notpeter added internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc and removed triage labels Nov 25, 2024
@ConradIrwin
Copy link
Member

@Dracks the default for Spanish cmd-. becomes cmd-ç.

In v0.162.x I shipped a change to automatically localize keyboard shortcuts. https://zed.dev/blog/keyboard-localization

If you want to restore this behavior

{
    "use_layout_keys": true // for Zed v0.162 ..= v0.165
    "context": "Workspace",
    "bindings": {
      "cmd-.": "editor::ToggleCodeActions"
    }
}

In v0.166 "use_layout_keys" will become the default.

@Dracks
Copy link
Author

Dracks commented Dec 7, 2024

Waw, I never thought the nightmare of shortkuts with internationalization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc
Projects
None yet
Development

No branches or pull requests

4 participants