Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db management data: remove all hardcoded id values #1844

Closed
vdelendik opened this issue Nov 7, 2019 · 0 comments
Closed

Db management data: remove all hardcoded id values #1844

vdelendik opened this issue Nov 7, 2019 · 0 comments

Comments

@vdelendik
Copy link
Contributor

INSERT INTO WIDGET_TEMPLATES ( ID, NAME, DESCRIPTION, TYPE, SQL, CHART_CONFIG, PARAMS_CONFIG, PARAMS_CONFIG_SAMPLE, HIDDEN) VALUES (17,'MILESTONE DETAILS', 'Consolidated test status trend with the ability to specify 10+ extra filters and grouping by hours, days, month, etc.', 'OTHER','<#global IGNORE_TOTAL_PARAMS = ["DEVICE", "APP_VERSION", "LOCALE", "LANGUAGE", "JOB_NAME", "PARENT_JOB...

17 is hardcoded id from widgets table. We have to review all db-mng queries to substitute id using sub-query from widgets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants