Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Italic Fonts on some Docs #658

Closed
elnasdgreat opened this issue Nov 19, 2016 · 10 comments · Fixed by #1125
Closed

Italic Fonts on some Docs #658

elnasdgreat opened this issue Nov 19, 2016 · 10 comments · Fixed by #1125
Labels
scope/packaging scope/ui/webview status/done status/upstream-problem type/defect
Milestone
0.7.0

Comments

@elnasdgreat
Copy link

elnasdgreat commented Nov 19, 2016 •
edited
Loading

Some of the Docs have italic fonts. Like the PHP doc. All of it is in italic font!
Can you please add an option for changing the fonts?
1
@trollixx
Copy link
Member

This is another Qt WebKit issue :( Should be fixed when we switch to the new version of the engine. Marking as a duplicate of #359.

@trollixx
Copy link
Member

Actually, I see this problem with the new Qt WebKit. Italic is coming from somewhere else...

@trollixx trollixx reopened this Aug 23, 2017
@trollixx trollixx added scope/misc/docsets and removed status/duplicate Duplicate of another issue. labels Aug 23, 2017
@trollixx
Copy link
Member

Somehow commenting the following in the CSS for Fira Sans font fixes the problem:

url('fonts/Fira/ttf/FiraSans-Book.ttf') format('truetype')
...
url('fonts/Fira/ttf/FiraSans-Medium.ttf') format('truetype')

Viewing php.net in Zeal also displays this bug.

@trollixx
Copy link
Member

Still looks like Qt WebKit bug, just a different one...

@trollixx
Copy link
Member

And here's the bug: qtwebkit/qtwebkit#270.

@trollixx trollixx mentioned this issue Aug 30, 2017
Closed
@trollixx trollixx mentioned this issue Oct 22, 2017
Closed
@trollixx trollixx mentioned this issue Nov 30, 2017
Closed
@annulen
Copy link

annulen commented Feb 13, 2019

Fix will be released in Qt 5.12.3, see https://bugreports.qt.io/browse/QTBUG-73660

@trollixx
Copy link
Member

@annulen thanks for the update!

I'll resolve the issue once we ship a new release with updated Qt.

@trollixx
Copy link
Member

Looks like the fix made it into 5.12.2. Will be released with v0.7.0 binaries.

@trollixx trollixx added this to the 0.7.0 milestone Mar 27, 2019
@trollixx trollixx linked a pull request Apr 25, 2020 that will close this issue
feat(browser,ui): port to Qt WebEngine #1125
Merged
trollixx pushed a commit that referenced this issue Apr 26, 2020
@kaygdev
feat(browser,ui): port to Qt WebEngine (#1125)
5360da3 
Fixes #658, #776, #868, #959, #1119, #1131, #1155, #1195.
@DenesKellner
Copy link

A horrible hack until the real solution happens:

  • Go to ...../PHP.docset/Contents/Resources/Documents/www.php.net/manual
  • Find all <body class="docs " style="">
  • Replace all to <body class="docs " style="font-family:sans-serif">

Yes it's a lot to replace.
But after that, it's a relief.

@Nickieros
Copy link

Somehow commenting the following in the CSS for Fira Sans font fixes the problem:

url('fonts/Fira/ttf/FiraSans-Book.ttf') format('truetype')
...
url('fonts/Fira/ttf/FiraSans-Medium.ttf') format('truetype')

Viewing php.net in Zeal also displays this bug.

@trollixx thanks, this works
I found this CSS file which contains FiraSans @font-face in PHP.docset\Contents\Resources\Documents\www.php.net
and used regex to comment all FiraSans urls with truetype format in this file:

use regex
/(.*format\(\'truetype\'\))/
to replace it with
/*$1*/

@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
scope/packaging scope/ui/webview status/done status/upstream-problem type/defect
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

feat(browser,ui): port to Qt WebEngine kaygdev/zeal
5 participants
@annulen @trollixx @DenesKellner @elnasdgreat @Nickieros