Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Select search bar" hotkey within search bar should select all text #1033

Closed
mcomella opened this issue Nov 10, 2018 · 4 comments
Closed

"Select search bar" hotkey within search bar should select all text #1033

mcomella opened this issue Nov 10, 2018 · 4 comments

Comments

@mcomella
Copy link

ctrl+L will focus the search bar and select all the text, like a browser. While the search bar has focus, in a browser ctrl+L will select all the text (i.e. the behavior doesn't change depending on what's focused) while in zeal ctrl+L will do nothing.

I propose we make ctrl+L select all the text no matter what is focused (particularly solving the issue where ctrl+L does nothing while the search bar is focused).

@mcomella mcomella changed the title ctrl+L within search bar should select all text "Select search bar" hotkey within search bar should select all text Nov 10, 2018
@mcomella
Copy link
Author

I noticed there are several keyboard shortcuts that can do this from #401:

  • ctrl+L
  • ctrl+k
  • ?

We should consider if these should also have the same behavior.

mcomella added a commit to mcomella/zeal that referenced this issue Nov 11, 2018
mcomella added a commit to mcomella/zeal that referenced this issue Nov 11, 2018
)

Previously, the search bar focus shortcut would only select all if the
search bar was not focused. This change makes select all happen all the
time, making the keyboard shortcut consistent no matter what is focused.
mcomella added a commit to mcomella/zeal that referenced this issue Nov 11, 2018
mcomella added a commit to mcomella/zeal that referenced this issue Nov 11, 2018
)

Previously, the search bar focus shortcut would only select all if the
search bar was not focused. This change makes select all happen all the
time, making the keyboard shortcut consistent no matter what is focused.
mcomella added a commit to mcomella/zeal that referenced this issue Nov 11, 2018
mcomella added a commit to mcomella/zeal that referenced this issue Nov 11, 2018
)

Previously, the search bar focus shortcut would only select all if the
search bar was not focused. This change makes select all happen all the
time, making the keyboard shortcut consistent no matter what is focused.
mcomella added a commit to mcomella/zeal that referenced this issue Nov 18, 2018
@evanricard
Copy link

I would like to just have a keyboard shortcut to navigate directly to the docset bar. Navigating through the different symbolic information of a given docset with the arrow keys (which we can already do by clicking the sidebar then using arrow keys) would be extremely helpful for me personally.

@trollixx
Copy link
Member

trollixx commented Mar 25, 2019

With the referenced change search box handles focus shortcuts more intelligently, and sets selection according to the current selection, or cursor position.

@evanricard Up and Down arrow keys should work exactly as you describe (navigate within the sidebar), if they don't with the most recent version (or better built from master), please create a new ticket. Also see #1007, which is related to this.

@lock
Copy link

lock bot commented Sep 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for a related request.

@lock lock bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants