Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate service account tokens before executing the 'op' cli command #120

Open
zcutlip opened this issue May 26, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@zcutlip
Copy link
Owner

zcutlip commented May 26, 2023

The format of the service account token is now documented here.

It should be relatively straightforward to decode and do some basic validation of a service account token prior to ever executing op.

This is in line with our goal of catching specific, precise errors without op reporting them, which is less precise, and requires scraping stderr.

There is currently an exception, OPCmdMalformedSvcAcctTokenException, which represents a malformed service account token as reported by op

We can add a new exception that represents a malformed service account token that we detect on our own

@zcutlip zcutlip self-assigned this May 26, 2023
@zcutlip zcutlip added the enhancement New feature or request label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant