Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/travis: fix opam install packages to locked io-page to 1.6.1 #182

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

zchee
Copy link
Member

@zchee zchee commented Jun 28, 2017

Update opam packages dependency to latest.
See also: https://github.com/moby/hyperkit#building

version locked io-page to 1.6.1.

@chuckyz
Copy link

chuckyz commented Jun 28, 2017

@zchee I took a shot at trying to fix this yesterday but don't understand ocaml well enough to really fix the issue.

The problem is that Qcow.Make expects two objects, which you can see here:

https://github.com/moby/hyperkit/blob/master/src/lib/mirage_block_ocaml.ml#L11

@zchee
Copy link
Member Author

zchee commented Jun 28, 2017

@chuckyz Thanks trying to fix it :)
It causes is OCaml packages dependency. Docker dev changed qcow-format to qcow, that maybe include destructive change.

We have two way of fix this issue. One of use specific version of qcow-format, Two of update libhyperkit to latest(which is this projects vendor package).
However, since the second option will change the internal structure significantly, it will be necessary to update the version of docker-machine-driver-xhyve.
We need to fix travis build way and change to be able to generate prebuild binary in the current version(for next release), So I choose the former.

I will try various versions to solve OCaml's dependencies. Anyway, thanks for follow up this issue.

@zchee zchee force-pushed the ci-travis-opam branch 3 times, most recently from 98228d4 to 032ff48 Compare June 29, 2017 01:15
io-page 2.0.0 (which required by mirage-block-unix) is no compatible
to qcow-format 0.5.0. io-page package to version locked to 1.6.1.

Signed-off-by: Koichi Shiraishi <[email protected]>
@zchee zchee changed the title ci/travis: fix opam install packages to correspond latest hyperkit ci/travis: fix opam install packages to locked io-page to 1.6.1 Jun 29, 2017
@zchee zchee merged commit 9807882 into master Jun 29, 2017
@zchee zchee deleted the ci-travis-opam branch June 29, 2017 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants