Ignore setupmounts #174
Merged
Ignore setupmounts #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 9p mount already exists in this case. This is reverting back to behavior before https://github.com/zchee/docker-machine-driver-xhyve/pull/161/files This now logs a warning, but this is a not fatal error on a recreate. I'm not sure there's a cleaner way since Start() has no context of if it is called on new VM or a recently stopped VM.
|
@r2d4 LGTM. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 9p mount already exists in this case. This is reverting back to a similar behavior before
https://github.com/zchee/docker-machine-driver-xhyve/pull/161/files
This now logs a warning, but this is a not fatal error on a recreate. I'm not sure there's
a cleaner way since Start() has no context of if it is called on new VM or a recently stopped VM.
Reference: kubernetes/minikube#1400 (comment)