Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetTreeState gRPC needs more updates for Orchard #438

Open
LarryRuane opened this issue Jun 8, 2023 · 0 comments
Open

GetTreeState gRPC needs more updates for Orchard #438

LarryRuane opened this issue Jun 8, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@LarryRuane
Copy link
Collaborator

#384 purported to add support for Orchard for GetTreeState, but it looks incomplete. The GetTreeState gRPC handler calls zcashd's z_gettreestate from within a loop. The loop continues, following the z_gettreestate's Sapling.SkipHash until Sapling.Commitments.FinalState is not empty.

What seems wrong is that Orchard's FinalState and SkipHash are not considered in this loop. I don't know what the correct fix is.
@LarryRuane LarryRuane added the bug Something isn't working label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LarryRuane