-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use iD presets #116
Comments
Hi @westnordost, I know about both these projects and I already tried once to use it to display the feature panel. But it was too early in the project and I decided against, I had more pressing issues. Now it could be a good time to revisit it :-) I already have a similar functionality for adding places - see #64 (preview). btw, thanks for your praise! very kind words. I am glad someone likes the project. 🙂 My original intention was to make it as good as google maps UI, but life kind of got in the way. 😃 I have just enough time to maintain, but not to develop much. |
Hi, wow, this turned out to be so cumbersome. Matching the tags against the preset was easy, but there are so many edge cases to solve, and unfortunately i wasnt able to use the iD code directly. See eg: https://osmapp-git-tagging-zbycz.vercel.app/way/34633854 Known issues, open questions:
|
Wow, cool! On the questions, I would try to keep close to however iD does that. StreetComplete only uses the presets to search by features and does not use the fields. So, not sure how the fields are structured. Maybe there is a certain order/favs already defined for these? (If not, this is definitely something that would make sense to add in the iD presets itself upstream). That, in general. I think a tooltip for starters would be enough. The preview-side-view (before one clicks the "edit") button IMO does not really need to show the actual tag keys at all. Tag value translations are by the way somewhat new and incomplete. |
Thanks :) I wanted to display as much data as possible, because honestly it is our gold, isn't it? Hiding any piece of it doesnt feel right. Maybe the raw tags could be collapsed by default, but sometimes even there are useful info - only waiting to be added as iD preset. ad wong fields) I think i will figure it out. iD shows only fields for preset, i am matching the other "possibly fields" on my own invention. Defintely a point to discuss with iD maintainers. ad actual tags) right, good point. Advananced users can check them in the edit dialog. I will explore more options, best design is iterative :) |
I too think that it would be nice to show any additional tags not recognized as a field by the presets below the translated ones in a collapsed "more data" or something like this section |
After a year of effort, i think id schema for OsmAPP is done 🎉 It was so so difficult 😅 see #197 I would be glad if you can report any issues or ideas here. |
Hi, thanks for this update! |
See https://github.com/openstreetmap/id-tagging-schema (+ https://github.com/osmlab/name-suggestion-index/)
I am really surprised that this project doesn't use them yet. Only when users are not forced to know the tags (by heart), this becomes a tool that can be used by non OSM experts. TBH, when it does, it is something I find should be used on osm.org itself in my opinion, but that is another story.
When you use the presets, you gain
shop=pet
when typing "dog")Almost all smartphone apps use iD presets one way or another (EveryDoor, StreetComplete, GoMap!!, OSM Go, ...).
In StreetComplete, I use a subset of this, i.e. only the features and not the fields. I use https://github.com/westnordost/osmfeatures to parse the preset.json. The feature search looks like this:
The text was updated successfully, but these errors were encountered: