Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iD presets #116

Closed
westnordost opened this issue Oct 17, 2022 · 8 comments · Fixed by #131 or #197
Closed

Use iD presets #116

westnordost opened this issue Oct 17, 2022 · 8 comments · Fixed by #131 or #197
Labels
new feature New feature or request

Comments

@westnordost
Copy link

See https://github.com/openstreetmap/id-tagging-schema (+ https://github.com/osmlab/name-suggestion-index/)

I am really surprised that this project doesn't use them yet. Only when users are not forced to know the tags (by heart), this becomes a tool that can be used by non OSM experts. TBH, when it does, it is something I find should be used on osm.org itself in my opinion, but that is another story.

When you use the presets, you gain

  • not having to maintain a list of features+icon yourself
  • localized feature names and thus search by that
  • terms for features with which one can find them (e.g. find shop=pet when typing "dog")
  • icons
  • a list of fields (e.g. phone, website, ... on POI features) which one could display for the user to fill out
  • for the fields, further information by what kind of UI they should be selected (e.g. is it a color, is it a multi-select etc...)

Almost all smartphone apps use iD presets one way or another (EveryDoor, StreetComplete, GoMap!!, OSM Go, ...).

In StreetComplete, I use a subset of this, i.e. only the features and not the fields. I use https://github.com/westnordost/osmfeatures to parse the preset.json. The feature search looks like this:

image

@zbycz
Copy link
Owner

zbycz commented Oct 17, 2022

Hi @westnordost, I know about both these projects and I already tried once to use it to display the feature panel. But it was too early in the project and I decided against, I had more pressing issues. Now it could be a good time to revisit it :-)

I already have a similar functionality for adding places - see #64 (preview).
But i had to remove it, because it was more confusing then helpful. I will try to start there with id-tagging-schema.

btw, thanks for your praise! very kind words. I am glad someone likes the project. 🙂 My original intention was to make it as good as google maps UI, but life kind of got in the way. 😃 I have just enough time to maintain, but not to develop much.

@zbycz
Copy link
Owner

zbycz commented Feb 26, 2023

Hi, wow, this turned out to be so cumbersome. Matching the tags against the preset was easy, but there are so many edge cases to solve, and unfortunately i wasnt able to use the iD code directly.
But after a month of coding, the prototype is finally working :) It would probably take twice as long to fine tune and refactor all the hacky code, but it is there, yes!

See eg: https://osmapp-git-tagging-zbycz.vercel.app/way/34633854

Known issues, open questions:

  1. Currently it has 4 catogories of fields: featured, from preset, standalone and unmatched tags. Unmatched tags should be perhaps collapsed by default?
  2. sometimes the standalone field is matched with wrong variation of the tag, eg here, ref is matched as fieldKey: ref_aeroway_gate
  3. i dont know how to show tags for advanced users yet. Something like a tooltip over every field? or expand icon? global checkbox?
  4. amharic language not working yet
  5. tag's value translations are missing sometimes as they are hardcoded in the field id ui code

@westnordost
Copy link
Author

Wow, cool! On the questions, I would try to keep close to however iD does that. StreetComplete only uses the presets to search by features and does not use the fields. So, not sure how the fields are structured. Maybe there is a certain order/favs already defined for these? (If not, this is definitely something that would make sense to add in the iD presets itself upstream).

That, in general.

I think a tooltip for starters would be enough. The preview-side-view (before one clicks the "edit") button IMO does not really need to show the actual tag keys at all.

Tag value translations are by the way somewhat new and incomplete.

@zbycz
Copy link
Owner

zbycz commented Feb 26, 2023

Thanks :)

I wanted to display as much data as possible, because honestly it is our gold, isn't it? Hiding any piece of it doesnt feel right. Maybe the raw tags could be collapsed by default, but sometimes even there are useful info - only waiting to be added as iD preset.

ad wong fields) I think i will figure it out. iD shows only fields for preset, i am matching the other "possibly fields" on my own invention. Defintely a point to discuss with iD maintainers.

ad actual tags) right, good point. Advananced users can check them in the edit dialog. I will explore more options, best design is iterative :)

@westnordost
Copy link
Author

I too think that it would be nice to show any additional tags not recognized as a field by the presets below the translated ones in a collapsed "more data" or something like this section

@orl0pl orl0pl linked a pull request May 9, 2023 that will close this issue
@Flohhhhh Flohhhhh added the new feature New feature or request label Jun 12, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Interesting issues in OsmAPP Jun 17, 2023
@zbycz
Copy link
Owner

zbycz commented Jun 17, 2023

Currently deployed to main site, but hidden in "advanced mode". If anyone wants to try, see here:
image

There are lot bugs to catch, I will migrate those to a new issue.

Reopening this one as it is not fully done.

@zbycz
Copy link
Owner

zbycz commented Oct 30, 2023

After a year of effort, i think id schema for OsmAPP is done 🎉 It was so so difficult 😅 see #197
You may test it live on https://osmapp.org. Clickable pois are still little broken on maptiler, but most of it works now.

I would be glad if you can report any issues or ideas here.
Also i would like to ask you - power users - do you need the "show tags" option? what is the usecase? Is current implementation ok? Thx.

cc @westnordost @Flohhhhh @Dlurak @kudlav

@zbycz zbycz closed this as completed Oct 30, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Interesting issues in OsmAPP Oct 30, 2023
@kudlav
Copy link
Contributor

kudlav commented Oct 30, 2023

Hi, thanks for this update!
I don't need Show tags option, as it's possible to click on the (i) and open the node on osm.org where I can see raw tag values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Status: Done
4 participants