Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include v3 in Dask's nightly CI when ready #1922

Closed
jrbourbeau opened this issue May 28, 2024 · 4 comments
Closed

Include v3 in Dask's nightly CI when ready #1922

jrbourbeau opened this issue May 28, 2024 · 4 comments
Milestone

Comments

@jrbourbeau
Copy link
Member

Over in Dask's nightly CI build that tests against nightly versions of Dask dependencies, we started seeing Zarr-related test failures like

FAILED dask/array/tests/test_array_core.py::test_from_zarr_unique_name - TypeError: 'module' object is not callable
FAILED dask/array/tests/test_array_core.py::test_from_zarr_name - TypeError: 'module' object is not callable
FAILED dask/array/tests/test_array_core.py::test_zarr_roundtrip - AttributeError: module 'zarr' has no attribute 'create'
FAILED dask/array/tests/test_array_core.py::test_zarr_roundtrip_with_path_like - AttributeError: module 'zarr' has no attribute 'create'
FAILED dask/array/tests/test_array_core.py::test_to_zarr_accepts_empty_array_without_exception_raised - AttributeError: module 'zarr' has no attribute 'create'
FAILED dask/array/tests/test_array_core.py::test_zarr_return_stored[False] - AttributeError: module 'zarr' has no attribute 'create'
FAILED dask/array/tests/test_array_core.py::test_zarr_return_stored[True] - AttributeError: module 'zarr' has no attribute 'create'
FAILED dask/array/tests/test_array_core.py::test_zarr_inline_array[True] - TypeError: 'module' object is not callable
FAILED dask/array/tests/test_array_core.py::test_zarr_inline_array[False] - TypeError: 'module' object is not callable
FAILED dask/array/tests/test_array_core.py::test_zarr_existing_array - AttributeError: module 'zarr' has no attribute 'zeros_like'
FAILED dask/array/tests/test_array_core.py::test_read_zarr_chunks - AttributeError: module 'zarr' has no attribute 'create'
FAILED dask/array/tests/test_array_core.py::test_zarr_pass_mapper - ModuleNotFoundError: No module named 'zarr.storage'

due to missing top-level attributes like zarr.create, zarr.zeros_like, etc. (see this build for full tracebacks).

I'm able to reproduce these types of errors locally (w/o dask) with the following steps:

mamba create -n test python=3.12
mamba activate test
pip install git+https://github.com/zarr-developers/zarr-python
python -c "import zarr; print(zarr.create)"

which raises this AttributeError

Traceback (most recent call last):
  File "<string>", line 1, in <module>
AttributeError: module 'zarr' has no attribute 'create'

With the latest zarr=2.18.2 release, I don't get an error

python -c "import zarr; print(zarr.create)"
<function create at 0x105295c60>

One odd thing is that pip install git+https://github.com/zarr-developers/zarr-python seems to be installing zarr-2.16.2.dev95+gb1f4c50, which seems off given the latest release is 2.18.2.

It's unclear to be if something has changed in this repo, or if we should update our "install the nightly version of Zarr" command over in dask/dask.

@jrbourbeau
Copy link
Member Author

Hmm looks like the default branch is v3 here and if we instead explicitly install from main

pip install git+https://github.com/zarr-developers/zarr-python.git@main

then things work as expected.

Could someone help me understand the difference between main and the (default) v3 branch?

@jhamman
Copy link
Member

jhamman commented May 29, 2024

@jrbourbeau - thanks for opening the issue. I recommend taking a look at #1777 for a summary of the v3 effort. In the short term, I suggest pointing to main as you have done. In the medium term, once our alpha release is out, we would love to get Dask's test suite running against the v3 branch again.

Also, #1884 will be fixing the specific errors you encountered.

@jhamman jhamman added the V3 label May 29, 2024
@jrbourbeau
Copy link
Member Author

Thanks for the extra context @jhamman, that's helpful

I suggest pointing to main as you have done

Cool, doing that here dask/dask#11151

once our alpha release is out, we would love to get Dask's test suite running against the v3 branch again

I'm happy to help out when that happens

@jrbourbeau jrbourbeau changed the title Development version of zarr missing attributes? Include v3 in Dask's nightly CI when ready May 31, 2024
@jhamman jhamman added this to the After 3.0.0 milestone Oct 17, 2024
@jhamman
Copy link
Member

jhamman commented Oct 17, 2024

closed by dask/dask#11388

@jhamman jhamman closed this as completed Oct 17, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Zarr-Python - 3.0 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants