Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement parameterised Workload.run & Dataset.prepare methods #6

Closed
JackKelly opened this issue Sep 30, 2023 · 1 comment
Closed

Implement parameterised Workload.run & Dataset.prepare methods #6

JackKelly opened this issue Sep 30, 2023 · 1 comment
Assignees
@JackKelly

Comments

@JackKelly
Copy link
Collaborator

JackKelly commented Sep 30, 2023 •
edited
Loading

Using same semantics as pytest.

https://github.com/pytest-dev/pytest/blob/main/src/_pytest/mark/structures.py#L151
@JackKelly JackKelly changed the title Implement parameterised Workload.run methods Implement parameterised Workload.run & Dataset.prepare methods Oct 1, 2023
@JackKelly JackKelly mentioned this issue Oct 6, 2023
Closed
@JackKelly JackKelly self-assigned this Oct 6, 2023
@JackKelly JackKelly moved this from Todo to In Progress in Zarr-Python - Benchmarking and Performance Oct 6, 2023
@JackKelly
Copy link
Collaborator Author

I have implemented a parametrize decorator. But, actually, I'm starting to think that's the wrong way to parameterize the creation of datasets. I think it's easier to just have multiple Dataset subclasses (one for each version).

@JackKelly JackKelly mentioned this issue Oct 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackKelly JackKelly

Labels
None yet
Projects
Zarr-Python - Benchmarking and Performance
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JackKelly