Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env vars for ZARF_LOG_LEVEL and ZARF_LOG_FORMAT #3222

Closed
Tracked by #3210
mkcp opened this issue Nov 8, 2024 · 1 comment
Closed
Tracked by #3210

Add env vars for ZARF_LOG_LEVEL and ZARF_LOG_FORMAT #3222

mkcp opened this issue Nov 8, 2024 · 1 comment
Assignees
Labels
enhancement ✨ New feature or request
Milestone

Comments

@mkcp
Copy link
Contributor

mkcp commented Nov 8, 2024

Is your feature request related to a problem? Please describe.

We don't support env vars for log level and format but these are nice to have for users.

Describe the behavior you'd like

When a user supplies an either the ZARF_LOG_LEVEL ZARF_LOG_FORMAT env var, these should percolate through the CLI layer and into logger setup. In the event that a flag is also supplied, the flag value takes precedence.

@mkcp mkcp added the enhancement ✨ New feature or request label Nov 8, 2024
@mkcp mkcp added this to Zarf Nov 8, 2024
@github-project-automation github-project-automation bot moved this to Triage in Zarf Nov 8, 2024
@mkcp mkcp moved this from Triage to Backlog in Zarf Nov 8, 2024
@mkcp mkcp mentioned this issue Nov 8, 2024
4 tasks
@mkcp mkcp self-assigned this Nov 21, 2024
@mkcp mkcp moved this from Backlog to In progress in Zarf Nov 21, 2024
@mkcp
Copy link
Contributor Author

mkcp commented Dec 4, 2024

Great news, this is already done with Viper's CLI setup. Neat! I went ahead and tested each combination of config that we added and we're feature complete here. Go team!

Screenshot 2024-12-04 at 15 10 12

@mkcp mkcp closed this as completed Dec 4, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Zarf Dec 4, 2024
@mkcp mkcp added this to the v0.44.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant