Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm overrides omitted when component is imported #2966

Closed
rjferguson21 opened this issue Sep 4, 2024 · 0 comments · Fixed by #2967
Closed

Helm overrides omitted when component is imported #2966

rjferguson21 opened this issue Sep 4, 2024 · 0 comments · Fixed by #2967

Comments

@rjferguson21
Copy link
Contributor

Environment

Device and OS: Linux
App version: v0.38.3
Kubernetes distro being used: N/A
Other:

Steps to reproduce

  1. Create a a/zarf.yaml
kind: ZarfPackageConfig
metadata:
  name: a
  description: example package A
  version: 0.0.1
components:
  - name: foo
    required: false
    default: true
    charts:
      - name: podinfo-compose
        version: 6.4.0
        url: oci://ghcr.io/stefanprodan/charts/podinfo
        namespace: podinfo-override
        releaseName: podinfo-override
  1. Create b/zarf.yaml which imports foo component from a/zarf.yaml and also contains helm override variables
kind: ZarfPackageConfig
metadata:
  name: b
  description: example package B
  version: 0.0.1
components:
  - name: foo
    import:
      path: ../a
    charts:
      - name: podinfo-compose
        variables:
          - name: B_COLOR
            description: color of component B
            path: color
  1. cd b && zarf package create .

Expected result

The component foo contains a chart named podinfo-compose that includes the Helm override variables including B_COLOR

- name: foo
  charts:
  - name: podinfo-compose
    version: 6.4.0
    url: oci://ghcr.io/stefanprodan/charts/podinfo
    namespace: podinfo-override
    releaseName: podinfo-override
    variables:
    - name: B_COLOR
      description: color of component B
      path: color

Actual Result

The component foo contains the Helm chart but is missing any variables defined in b/zarf.yaml, including B_COLOR

Visual Proof (screenshots, videos, text, etc)

2024-09-04_16-09-1725483948

Severity/Priority

Medium

Additional Context

We've been experimenting using Helm overrides at the Zarf layer in UDS Core and would like to push some of our bundle level variables into Zarf vars to ensure a consistent interface for consumers of UDS Core who generally are consuming the uds-core package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant