Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for image volume source #2902

Open
brandtkeller opened this issue Aug 16, 2024 · 2 comments
Open

Support for image volume source #2902

brandtkeller opened this issue Aug 16, 2024 · 2 comments
Labels
enhancement ✨ New feature or request

Comments

@brandtkeller
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Kubernetes 1.31 introduced image volume source in alpha.

As this is an associated OCI artifact - Zarf may require the need to be checking for images used as volumes during mutation in the agent.

Describe the solution you'd like

  • Given a pod uses an image volume source
  • When the mutation of a pod ocurs
  • Then the image reference is updated to the zarf registry

Additional context

KEP-4639

Understand this is an alpha feature that requires the ImageVolume feature gate - opening this issue for tracking intent to support if not intending to support until graduation.

@brandtkeller brandtkeller added the enhancement ✨ New feature or request label Aug 16, 2024
@AustinAbro321
Copy link
Contributor

IMO given that this would be a simple, nonbreaking, change to the agent, this is something that doesn't need to wait until graduation to implement. IMO it'll be reasonable to add once tools like k3s and eks support 1.31

@salaxander salaxander added this to Zarf Aug 21, 2024
@salaxander salaxander moved this to Backlog in Zarf Aug 21, 2024
@phillebaba
Copy link
Contributor

This needs to be discussed, regarding if we want to support Alpha features. I am a fan of OCI volumes but this feature will change in the future.

@AustinAbro321 this will not hit EKS when 1.31 gets there. Alpha features and for a while now Beta feature are disabled by default. We wont see any major adoption until it gets into a graduated state.

If we end up supporting this for a specific use case it should be marked with a big experimental flag that allows us to break it at any time.

@a1994sc a1994sc mentioned this issue Nov 20, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

3 participants