-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add a benchmark test for image pulls #2423
Comments
3 tasks
lucasrod16
changed the title
add a benchmark test for image pulls
test: add a benchmark test for image pulls
Apr 8, 2024
This benchmark should also cover cold vs warm caches |
In hindsight, this is likely a premature optimization. If we feel the need to measure the performance of image pulls with a benchmark test in the future, we can reopen this issue or create a new one. See rules 1 and 2 in Rob Pike's 5 Rules of Programming: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what should be investigated or refactored
A benchmark test should be added for the
PullAll()
functionLinks to any relevant code
https://github.com/defenseunicorns/zarf/blob/02389274c61b59385ac339d6d690a148878427f9/src/internal/packager/images/pull.go#L39
Additional context
This benchmark test will serve as a baseline for what we expect the performance of image pulls to be.
Example benchmark used to test #2409:
The text was updated successfully, but these errors were encountered: