Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.zarf-state.yaml could use a bit more robustness #206

Closed
YrrepNoj opened this issue Dec 14, 2021 · 2 comments · Fixed by #237
Closed

.zarf-state.yaml could use a bit more robustness #206

YrrepNoj opened this issue Dec 14, 2021 · 2 comments · Fixed by #237
Assignees

Comments

@YrrepNoj
Copy link
Contributor

YrrepNoj commented Dec 14, 2021

Two potential improvements on the current condition of the .zarf-state.yaml file.

  1. Add a check (and warning log / confirmation dialog if not in --confirm) that a .zarf-state.yaml file already exists.

  2. Right now the code only checks for a .zarf-state.yaml file in the current directory. This can create several issues, most of them revolving around the fact that we will be leaving behind lingering state files (zarf destroy only removes the state file if it's in the same directory you ran the command from) and the fact that if we init in one directory and switch directories before the zarf deploy command we will no longer be able to find the state file to reference which leads to an unclear set of logs.

This can be replicated by running the following commands:
./zarf init
mkdir testdir && cd testdir
../zarf destroy --confirm
ls -la ../.zarf-state.yaml -> it is still there after it was supposed to be destroyed.

@jeff-mccoy
Copy link
Contributor

this is a valid point, I wouldn't be opposed to just doing an /etc/zarf thing instead, might actually be cleaner to put all state things there instead. Thoughts?

@RothAndrew RothAndrew moved this from New Requests to Planned in Zarf Project Board Jan 10, 2022
@RothAndrew RothAndrew moved this to New Requests in Zarf Project Board Jan 10, 2022
@YrrepNoj
Copy link
Contributor Author

This will get resolved by #153

@YrrepNoj YrrepNoj linked a pull request Jan 31, 2022 that will close this issue
24 tasks
@RothAndrew RothAndrew moved this from Planned to Doing Now in Zarf Project Board Jan 31, 2022
Repository owner moved this from Doing Now to Done in Zarf Project Board Feb 8, 2022
@Racer159 Racer159 moved this to Done in Zarf Project Board Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants