-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct AJAX calls not getting upgraded to https #530
Comments
Note: we have tested with JuiceShop locally and that seems to work well. |
Tried a very simple test locally, and when the ajax call specified the http url then the app failed when the HUD was enabled with: |
One option would be to replace all of the http:// strings with https:// ones for the domains that we know we have upgraded. |
We would have to replace in "all" files (e.g. JavaScript). HSTS would be better as we wouldn't need to manually change the schemes (assuming the target is the same). |
Oooh, I like that idea :) |
That has its problems too, like forcing to HTTPS even if you are no longer proxying through ZAP (it would be fine with launched browsers). |
Hi @psiinon The specific error I et in the browser console is: The error is happening on the page used for authentication when a Javascript library loaded on the page attempts to make a call to the server as part of the page load. |
Thanks @wonboyn - is the http:// server url hqardcoded in the HTML? If so then we have a plan that should fix that... |
Hello Simon, I am also noticing this issue. I am running a scala-play microservice locally. We have configured Chrome browser in our selenium tests to proxy through ZAP. In ZAP 2.8.0, with HUD (0.4.0) enabled, request to localhost is converted to https and fails to load the page with the below message on the browser:
When I disable HUD, the page is loaded (with http being the protocol). But if I launch the browser from ZAP UI, with HUD enabled, the page is loaded even with https. I can see a fix has been merged in 0.5.0. Do you think this issue would get resolved with the above fix? Thanks. |
@ejayaraman I would recommend disabling the HUD with your selenium tests. The HUD is designed to help manual testing and could well interfere with automated tests, which is why the HUD is disabled by default when ZAP is run in daemon mode. |
Thanks Simon. That helps. |
As per https://groups.google.com/d/msg/zaproxy-users/byxt8JvbkZU/PNd6ASRBBAAJ
This could cause problems with lots of modern web apps, so we should investigate this asap.
The text was updated successfully, but these errors were encountered: