Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to History tool #233

Closed
dscrobonia opened this issue Nov 6, 2018 · 0 comments · Fixed by #286
Closed

Add filter to History tool #233

dscrobonia opened this issue Nov 6, 2018 · 0 comments · Fixed by #286
Labels
enhancement Good First Issue This is a great issue for a first time contributor to start with.
Milestone

Comments

@dscrobonia
Copy link
Contributor

dscrobonia commented Nov 6, 2018

Description

The History tool displays http requests that have been sent since the target page was was loaded. Often there can be a lot of messages, and you may only want to see certain types of messages. To help this we want to add support to add a search or regex feature that would remove messages that didn't match.

There are a number of different ways we could support this, but I think the most cohesive way is to follow the way dev tools work with a single search bar that supports searching and filtering:
image

Requirements

  • This change will likely be limited to tool/history.js, drawer.js, drawer.html, drawer.css.
  • Need to design the search bar element.
  • Need to be able to persist the filter between page loads (use localstorage)
  • Should perform some filtering, searching, or fuzzy matching to give the expected results.
@dscrobonia dscrobonia added enhancement Good First Issue This is a great issue for a first time contributor to start with. labels Nov 6, 2018
@jaywon jaywon self-assigned this Nov 26, 2018
@thc202 thc202 added this to the 0.3.0 milestone Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Good First Issue This is a great issue for a first time contributor to start with.
Development

Successfully merging a pull request may close this issue.

3 participants