2 test failures on OS X around ztime in test-pdc.h

[ileanadumitrescu95]

SourceForge bug #197 written by Hanspeter Niederstrasser on 2013-10-15

Building libzvbi 0.2.35 on OS X 10.7, and running tests with make check, they fail with this error. The build seems otherwise OK.

PASS: test-hamm
Assertion failed: (NULL != strptime (s, "%n%Y%m%dT%H%M%S", &tm)), function ztime, file ./test-pdc.h, line 142.
/bin/sh: line 1: 92246 Abort trap: 6           ${dir}$tst
FAIL: test-packet-830
Assertion failed: (NULL != strptime (s, "%n%Y%m%dT%H%M%S", &tm)), function ztime, file ./test-pdc.h, line 142.
/bin/sh: line 1: 92267 Abort trap: 6           ${dir}$tst
FAIL: test-pdc
PASS: test-raw_decoder
PASS: test-unicode
PASS: test-vps
====================
2 of 18 tests failed
====================

[ririsoft]

Hello,

Looking at

zvbi/test/test-pdc.h

Line 150 in b4cef50

assert (NULL != strptime (s, "%n%Y%m%dT%H%M%S", &tm));

I do not understand how those tests could even pass on Linux. The time format sounds wrong : "%n" represents a newline that is not used in the time string passed to time in the tests.

[ririsoft]

Also looking at

zvbi/test/test-pdc.h

Line 152 in b4cef50

t = timegm (&tm);

it does not work with time below 1900 on MacOS (see apple source code for libc).

So this test

zvbi/test/test-packet-830.cc

Line 357 in b4cef50

(buffer1, TRUE, ztime ("18581117T000000"), 0);

cannot work on MacOS