Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idl_a_demux_feed not removing dummy bytes correctly #51

Open
ZXGuesser opened this issue May 15, 2024 · 1 comment
Open

idl_a_demux_feed not removing dummy bytes correctly #51

ZXGuesser opened this issue May 15, 2024 · 1 comment

Comments

@ZXGuesser
Copy link

This code appears to be simply counting the total number of 0x00 and 0xFF bytes within an IDL A payload, and skipping a byte when either count reaches 8, rather than counting only consecutive 0x00 or 0xFF bytes.

Additionally it appears to be skipping the 8th 0x00 or 0xFF byte rather than skipping the following byte which I understand to be the position of the dummy byte.

@ZXGuesser
Copy link
Author

I believe the attached patch corrects the behaviour of dummy byte removal, however I now have questions about other parts of this code.

The flags variable doesn't appear to be used, with the VBI_IDL_DEPENDENT flag never getting set in dx->flags.
In addition dx->flags doesn't appear to be being initialised anywhere, so holds spurious values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant