You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Exiting loop fails if any of I/O with AWS Performance Insight fails. I've not found a good way to achieve graceful degradation because all fetched metrics are used later by the "rules" engine.
I would not change the behaviour of the function, I would fail also if any of in.fetch request fails. The first error would be sufficient to return.
The ordering does not matter. Please not the results of in.fetch are aggregated into map. The rule engine uses metrics name and fetched from the map (in Golang oder of keys is non deterministic in the map).
The utility fetches samples sequentially, for large jobs it might take seconds. It would be beneficial to run it in parallel.
https://github.com/zalando/rds-health/blob/main/internal/insight/insight.go#L68
The text was updated successfully, but these errors were encountered: