Skip to content
This repository has been archived by the owner on May 26, 2020. It is now read-only.

Add hide/show unfiltered json button #99

Merged

Conversation

akread
Copy link
Contributor

@akread akread commented Aug 6, 2018

Also includes an option for default behavior on load.

screen shot 2018-08-06 at 8 23 13 am

screen shot 2018-08-06 at 8 23 22 am

screen shot 2018-08-06 at 8 23 31 am

Also includes an option for default behavior on load.
@raphaeleidus
Copy link
Contributor

hey @akread this is great.
In the discussion here: #93
It was suggested that if there is no filter at all just show the original input.
Do you think this PR would be easy to extend to have "Single Panel View" available for both input and output?

@akread
Copy link
Contributor Author

akread commented Aug 6, 2018

If you hide the unfiltered json by default that is essentially what you will have. On load you will only see one panel with the default query (which is the entire json object).

Does that suffice or are we envisioning something else?

@raphaeleidus
Copy link
Contributor

my question is more around how hard would it be to extend to allow manual toggling back and forth so if you do have a filter you could still go to full screen.

But this looks good to me as is.

Copy link
Contributor

@raphaeleidus raphaeleidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@mrandi
Copy link
Member

mrandi commented Aug 6, 2018

👍

@mrandi
Copy link
Member

mrandi commented Aug 6, 2018

the same for me :) thank you both!

@anstit
Copy link
Member

anstit commented Aug 6, 2018

Thanks, this looks great!

@anstit
Copy link
Member

anstit commented Aug 6, 2018

👍

@mrandi mrandi merged commit fed330d into zalando-incubator:master Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants