Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to bump binary version? #46

Closed
bibstha opened this issue Aug 9, 2018 · 8 comments
Closed

How to bump binary version? #46

bibstha opened this issue Aug 9, 2018 · 8 comments

Comments

@bibstha
Copy link

bibstha commented Aug 9, 2018

From https://wkhtmltopdf.org/downloads.html I can see that OSX version comes in 32bit and 64bit .pkg and can be extracted from it.
For linux, there are individual files for ubuntu and debian 32 and 64 bit, and I guess we can extract the binary out of one?

Can someone write a script or instructions on how to extract these?
I can help with a PR for 0.12.5

@besi
Copy link

besi commented Sep 19, 2018

I also need the 0.12.5 version since due to the following issue wkhtmltopdf/wkhtmltopdf#3241

@unixmonkey
Copy link
Collaborator

@bibstha Please do!

There's a PR here, but it's incomplete. I'll gladly close that one and merge a new one.

Pretty much all it needs is all the binaries to be replaced with the actual release versions, the version number changed, and a note in the changelog. Here's the commit updating to 0.12.4 for reference.

I would suggest you also try and test it out to make sure they are runnable on their target systems, and report back with what you tried (OS/Distro/version). If you can't do that, that's ok, too. I can help.

Looking forward to it!

@mileszs
Copy link

mileszs commented Feb 19, 2019

@unixmonkey @besi @bibstha I was going to update this, but there's an issue. It looks like the wkhtmltopdf project has decided to no longer include the compiled, generic binaries, based on their FAQ. Correct me if I'm mistaken in my conclusion, but it reads:

Where are the “generic” Linux builds?
The above binaries depend on packages provided by your distribution. Due to incompatibilities between library versions provided by each distribution, the only option is to use static linking – hence removed for now.

https://wkhtmltopdf.org/downloads.html

@unixmonkey
Copy link
Collaborator

@mileszs 0.12.4 had the same issue, and we released a "good enough" version that worked on at least Ubuntu-based linux systems based on the binaries provided, and I think that's what we are looking for here. This gem won't work for everyone, but should be a convenience for those who use an OS that binaries are available for.

@mileszs
Copy link

mileszs commented Feb 19, 2019

@unixmonkey Ah, cool. I will try to do that when I have the chance.

@joergschiller
Copy link
Contributor

@unixmonkey maybe you can have a look at #49 - it might be more complete than #45

@pedrofurtado
Copy link
Contributor

@unixmonkey @zakird @mileszs Any progress will be appreciated 🤝 ☕ Anything we could help? Because I really don't know how to build this binary, in order to create myself a PR with this update 👍

@unixmonkey
Copy link
Collaborator

Closing this because we have released 0.12.5 (and a few patch versions), so the process with new binaries is more straightforward now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants