Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only getting a small portion of page #17

Open
JetsonDavis opened this issue Aug 11, 2020 · 4 comments
Open

Only getting a small portion of page #17

JetsonDavis opened this issue Aug 11, 2020 · 4 comments

Comments

@JetsonDavis
Copy link

I have xpi extension installed on Firefox and clicking 'Save Whole Page'. I get a pop-up dialog at the bottom of the screen. When I click the link and go to Trillium, I only get a small portion of text from the page. Am I doing something wrong?

For example, say I do a google search for 'nothing'. All I get is the top of the page.

image

@zadam
Copy link
Owner

zadam commented Aug 11, 2020

Hi, I can reproduce this behavior on the google search results page.

Trilium is not saving the page "as is" (which would be difficult anyway), but it's trying to extract the meaningful content using the https://github.com/mozilla/readability library. That involves some guesswork though and while it's mostly correct, it can be wrong at times. Google search result isn't really a typical usecase for this but yeah, I guess omitting the actual results is probably wrong thing to do.

So this would have to be fixed in the readability library first ...

@JetsonDavis
Copy link
Author

JetsonDavis commented Aug 11, 2020 via email

@zadam
Copy link
Owner

zadam commented Aug 11, 2020

Can you give some non-google example?

There's mobile frontend: https://github.com/zadam/trilium/wiki/Mobile-frontend

But native Android/iOS apps are probably not going to happen.

@JetsonDavis
Copy link
Author

JetsonDavis commented Aug 12, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants