Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version is a breaking change #10

Open
chrisduerr opened this issue Jan 30, 2020 · 2 comments
Open

Latest version is a breaking change #10

chrisduerr opened this issue Jan 30, 2020 · 2 comments

Comments

@chrisduerr
Copy link
Collaborator

It looks like the 0.4.4 was a breaking change, but it was not tagged as such.

Could this version be yanked and instead republished as 0.5.0?

@kchibisov
Copy link

I'd also like to add that breakage happened with the following log. As far as I can see there was a change related to bindgen, so maybe something went wrong?

error[E0425]: cannot find value `WINPTY_MOUSE_MODE_NONE` in this scope

   --> winpty\src\windows.rs:114:32

    |

114 |             MouseMode::None => WINPTY_MOUSE_MODE_NONE,

    |                                ^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find value `WINPTY_MOUSE_MODE_AUTO` in this scope

   --> winpty\src\windows.rs:115:32

    |

115 |             MouseMode::Auto => WINPTY_MOUSE_MODE_AUTO,

    |                                ^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find value `WINPTY_MOUSE_MODE_FORCE` in this scope

   --> winpty\src\windows.rs:116:33

    |

116 |             MouseMode::Force => WINPTY_MOUSE_MODE_FORCE,

    |                                 ^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find value `WINPTY_MOUSE_MODE_NONE` in this scope

   --> winpty\src\windows.rs:114:32

    |

114 |             MouseMode::None => WINPTY_MOUSE_MODE_NONE,

    |                                ^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find value `WINPTY_MOUSE_MODE_AUTO` in this scope

   --> winpty\src\windows.rs:115:32

    |

115 |             MouseMode::Auto => WINPTY_MOUSE_MODE_AUTO,

    |                                ^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find value `WINPTY_MOUSE_MODE_FORCE` in this scope

   --> winpty\src\windows.rs:116:33

    |

116 |             MouseMode::Force => WINPTY_MOUSE_MODE_FORCE,

    |                                 ^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope


@zacps
Copy link
Owner

zacps commented Feb 16, 2020

This was a bug which should have been fixed in #9. I've published a patch version which should hopefully fix the issue.

Sorry for getting to this late, for some reason I missed the notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants