Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit action node ignores the "block input overrides" checkbox #1641

Closed
chriswood1001 opened this issue Oct 9, 2024 · 0 comments · Fixed by #1644
Closed

Edit action node ignores the "block input overrides" checkbox #1641

chriswood1001 opened this issue Oct 9, 2024 · 0 comments · Fixed by #1644
Labels
bug Something isn't working node:action

Comments

@chriswood1001
Copy link

Describe the bug

The Edit Action Node does not obey the "Block input overrides" checkbox for data attributes.

To Reproduce

Create a node and complete all the entry items. For example:

Server:
Action: select.select_option
Target entity: select.my_entity_id
Data: {"option": "my option value"}
Show debug information: Checked
Block input overrides: Checked

Create an inbound inject node, and set payload overrides (expecting them to be blocked).
msg.payload = {"action": "light.turn_on", "data":{"kelvin":2700}}

Deploy and run.

Expected behavior

The Action Node is expected to block or otherwise ignore any inbound attributes in msg.payload.
It DOES ignore the inbound payload action: light.turn_on and properly sends "select.select_option"
It DOES NOT ignore the inbound payload data: {data:{kelvin:2700}} and improperly sends that instead of {option: "my option value"}

Screenshots

No response

Example Flow

[
    {
        "id": "e1ea23b972a3601e",
        "type": "api-call-service",
        "z": "377f019b5f12049d",
        "g": "a136f6beec307b50",
        "name": "Set mode to: Vacancy",
        "server": "64cfb96de88551f6",
        "version": 7,
        "debugenabled": true,
        "action": "select.select_option",
        "floorId": [],
        "areaId": [],
        "deviceId": [],
        "entityId": [
            "select.bathroomchildren_operation_mode"
        ],
        "labelId": [],
        "data": "{\"option\": \"Vacancy\"}",
        "dataType": "json",
        "mergeContext": "",
        "mustacheAltTags": false,
        "outputProperties": [],
        "queue": "none",
        "blockInputOverrides": true,
        "domain": "select",
        "service": "select_option",
        "x": 600,
        "y": 1420,
        "wires": [
            []
        ],
        "icon": "font-awesome/fa-arrow-circle-o-right"
    },
    {
        "id": "64c6bd73a0a26697",
        "type": "inject",
        "z": "377f019b5f12049d",
        "g": "a136f6beec307b50",
        "name": "",
        "props": [
            {
                "p": "payload"
            }
        ],
        "repeat": "",
        "crontab": "",
        "once": false,
        "onceDelay": 0.1,
        "topic": "",
        "payload": "{\"action\":\"light.turn_on\",\"data\":{\"kelvin\":2700,\"brightness_pct\":1}}",
        "payloadType": "json",
        "x": 410,
        "y": 1420,
        "wires": [
            [
                "e1ea23b972a3601e"
            ]
        ]
    },
    {
        "id": "64cfb96de88551f6",
        "type": "server",
        "name": "Home Assistant",
        "version": 5,
        "addon": false,
        "rejectUnauthorizedCerts": true,
        "ha_boolean": "y|yes|true|on|home|open",
        "connectionDelay": true,
        "cacheJson": true,
        "heartbeat": true,
        "heartbeatInterval": "30",
        "areaSelector": "friendlyName",
        "deviceSelector": "friendlyName",
        "entitySelector": "friendlyName",
        "statusSeparator": "at: ",
        "statusYear": "hidden",
        "statusMonth": "short",
        "statusDay": "numeric",
        "statusHourCycle": "h23",
        "statusTimeFormat": "h:m",
        "enableGlobalContextStore": true
    }
]

Environment Information

Version: 0.73.0

Home Assistant version: 2024.10.1
Companion version: 0.0.0

Node-RED version: 4.0.3
Docker: yes
Add-on: no

Node.js version: v20.17.0 x64 linux
OS: Linux 6.5.13-1-pve x64

Additional context

No response

@zachowj zachowj added bug Something isn't working node:action labels Oct 9, 2024
@zachowj zachowj closed this as completed in ef6e47b Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working node:action
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants