Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change on call service node #136

Closed
manonstreet opened this issue Jul 27, 2019 · 2 comments
Closed

Breaking change on call service node #136

manonstreet opened this issue Jul 27, 2019 · 2 comments

Comments

@manonstreet
Copy link

Describe the bug
Multiple comma delimited entity_ids provided in the Entity_Id field to the call service node works as expected in the prior version and as per the inline help. After upgrading the call service node, the call succeeds however no action is taken.

To Reproduce
While in Node Red:

  1. If there is an existing un-upgraded node with multiple comma delimited entity_ids, test and verify that it works as expected.
  2. Make a copy of the node, and edit it. Without making any changes, click Done to upgrade the node to version 1. Test again and observe that the call service succeeds however no action was taken.

Expected behavior
The call service should be called for each entity_id provided

Environment (please complete the following information):

@zachowj
Copy link
Owner

zachowj commented Jul 27, 2019

What domain are you using are you? I just tried to replicate this with input_booleans and it's working as intended.

[{"id":"b2de48d0.3ee368","type":"api-call-service","z":"fac037bf.a42d78","name":"test22","version":0,"service_domain":"input_boolean","service":"toggle","data":"{\"entity_id\": \"input_boolean.test, input_boolean.test2\"}","dataType":"jsonata","mergecontext":"","output_location":"payload","output_location_type":"msg","mustacheAltTags":false,"x":274,"y":400,"wires":[["bc0d1c2d.789b4"]]},{"id":"184955a0.1168aa","type":"inject","z":"fac037bf.a42d78","name":"","topic":"","payload":"","payloadType":"date","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":124,"y":400,"wires":[["b2de48d0.3ee368"]]},{"id":"bc0d1c2d.789b4","type":"debug","z":"fac037bf.a42d78","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"payload","targetType":"msg","x":552,"y":400,"wires":[]},{"id":"871df3bc.b101c","type":"api-call-service","z":"fac037bf.a42d78","name":"test22","version":1,"service_domain":"input_boolean","service":"toggle","entityId":"input_boolean.test, input_boolean.test2","data":"","dataType":"jsonata","mergecontext":"","output_location":"payload","output_location_type":"msg","mustacheAltTags":false,"x":274,"y":448,"wires":[["22f2090e.c5c396"]]},{"id":"231bf26e.011ffe","type":"inject","z":"fac037bf.a42d78","name":"","topic":"","payload":"","payloadType":"date","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":124,"y":448,"wires":[["871df3bc.b101c"]]},{"id":"22f2090e.c5c396","type":"debug","z":"fac037bf.a42d78","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"payload","targetType":"msg","x":552,"y":448,"wires":[]}]

@manonstreet
Copy link
Author

manonstreet commented Jul 27, 2019

After further testing, it definitely impacts the homeassistant domain, but I'm not certain if impacts others.

The first code successfully turns the scene and switch on whereas the second does not. However the output does not indicate the success or failure:

[{"id":"8574ce3.434da3","type":"inject","z":"922aca5d.23efa8","name":"","topic":"","payload":"","payloadType":"date","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":280,"y":640,"wires":[["2bde1585.2dce6a"]]},{"id":"2bde1585.2dce6a","type":"api-call-service","z":"922aca5d.23efa8","name":"Turn On Night Lights & Loft","server":"1f559d3b.d63813","version":0,"service_domain":"homeassistant","service":"turn_on","data":"{\"entity_id\":[\"scene.night_light\",\"switch.loft_switch\"]}","mergecontext":"","output_location":"","output_location_type":"none","x":500,"y":640,"wires":[["6d55016e.68e1a"]],"info":"Leave the living room lamp on (not in first floor group) since that's on a timer.\n\nAlso leave the hallway on for a minute to allow us to see and get upstairs."},{"id":"47275feb.0741f","type":"inject","z":"922aca5d.23efa8","name":"","topic":"","payload":"","payloadType":"date","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":280,"y":700,"wires":[["cc329000.ce7be"]]},{"id":"cc329000.ce7be","type":"api-call-service","z":"922aca5d.23efa8","name":"Turn On Night Lights & Loft","server":"1f559d3b.d63813","version":"1","service_domain":"homeassistant","service":"turn_on","entityId":"scene.night_light,switch.loft_switch","data":"","dataType":"json","mergecontext":"","output_location":"","output_location_type":"none","mustacheAltTags":false,"x":500,"y":700,"wires":[["9a51e4c4.147358"]],"info":"Leave the living room lamp on (not in first floor group) since that's on a timer.\n\nAlso leave the hallway on for a minute to allow us to see and get upstairs."},{"id":"6d55016e.68e1a","type":"debug","z":"922aca5d.23efa8","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"payload","targetType":"msg","x":750,"y":640,"wires":[]},{"id":"9a51e4c4.147358","type":"debug","z":"922aca5d.23efa8","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"payload","targetType":"msg","x":750,"y":700,"wires":[]},{"id":"1f559d3b.d63813","type":"server","z":"","name":"Home Assistant"}]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants