Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure during loading due to MQTT init #239

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Fix failure during loading due to MQTT init #239

merged 1 commit into from
Jan 5, 2024

Conversation

zvirja
Copy link
Contributor

@zvirja zvirja commented Jan 5, 2024

Fixes #238

Add MQTT to dependencies to make sure that component is loaded after it, so initialization does not fail

@zachowj
Copy link
Owner

zachowj commented Jan 5, 2024

@zvirja
Copy link
Contributor Author

zvirja commented Jan 5, 2024

@zachowj Yeah, also saw that hint in the CI output. Brilliant!! I've tested it locally and it seems to work as a charm 😊

@zvirja
Copy link
Contributor Author

zvirja commented Jan 5, 2024

@zachowj I believe that I fixed the ordering the that validation will be fine. I however don't know why the test is failing - it does not seem to be related to the change I did. Could you please help with that?

Thank you!

@zachowj
Copy link
Owner

zachowj commented Jan 5, 2024

Yeah, testing is broken at the moment. Your latest push removed the previous commit code.

@zvirja
Copy link
Contributor Author

zvirja commented Jan 5, 2024

Yeah, I force pushed to clean up the mess and the previous approach I took. Feel free to add more to PR if needed - I am done 😊

@zachowj
Copy link
Owner

zachowj commented Jan 5, 2024

Oh sorry, I didn't follow. I thought awaiting for the mqtt to load was still needed in the setup, but I guess after_dependences handles that outside the code.

@zachowj zachowj merged commit 6302ea6 into zachowj:main Jan 5, 2024
2 of 3 checks passed
@zvirja zvirja deleted the fix-mqtt-loading branch January 5, 2024 22:04
@zachowj
Copy link
Owner

zachowj commented Jan 5, 2024

thx

@zvirja
Copy link
Contributor Author

zvirja commented Jan 5, 2024

Exactly, now HASS does it for us, so the fix is neat. If you find other issues like this - simply add them as well to after_deps - that should be scalable until you add all of them!

Thank you very much for the fast feedback loop. I appreciate it a lot! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component might not initialize correctly with MQTT due to order
2 participants