Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS - columns margin should be calculated using $gutter value #16

Open
ilu2112 opened this issue Feb 3, 2017 · 1 comment
Open

SCSS - columns margin should be calculated using $gutter value #16

ilu2112 opened this issue Feb 3, 2017 · 1 comment

Comments

@ilu2112
Copy link

ilu2112 commented Feb 3, 2017

Check https://github.com/zachacole/Simple-Grid/blob/master/simple-grid.scss#L133:

.row [class^="col"] {
  float: left;
  margin: 0.5rem 2%;
  min-height: 0.125rem;
}

I guess You should change 2% in margin: 0.5rem 2%; to ($gutter / 2). Am I right?

@jbelelieu
Copy link

Retweet! The gutter isn't being respected in the final calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants