-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Energy Sites #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please address the version/changelog reversion and lint errors and we'll get this merged in this weekend.
Ok, I think I took care of all the comments you left. Let me know! |
feat: added support for energy sites (#219)
Hey @giachello, I'm helping with the rewrite and had a question on some changes in this pull request (thanks for adding this by the way!). I was wondering what the thought was behind mapping the site_id to energysite_id?
It looks like all the power data is stored in |
Actually, I think I've just done that for completeness, to conform with the way that the Car entities were written at the time. Not sure if there is a real need to do this. |
CarIDs are subject to change so it's possible they may change within a session so we had to translate it. If the energy sites cannot change, then you wouldn't need it. |
Ahh okay, that makes sense. I'm not 100% certain but I have not noticed the energy_site_id change. I haven't really looked closely at just the "id", but I'll keep an eye on it. Thanks! |
I added support for Energy Sites (Solar Panels). This has been working for my installation for a week now and feeds into my Energy panel on Home Assistant. I know you wanted to restructure the entire API in a separate thread on this topic, but I'm not going to do that work (don't have the time).
This goes together with a pull request on the Tesla custom component.