-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO list for release 0.5.11 #1785
Comments
About loudnessDb, will be better to set it from adaptiveFormats when audioConfig its missing |
@th3y while this will get you some value for
Different clients can have different normalization targets which means the volume will be different depending on which client is used. This will not be a great user experience since users can get mixed volume targets and this defeats the purpose of normalization. The only one of the current clients (the recent ones from my PR) which seems to provide the values as before is the Also
But for this to work there needs to be a way to detect if an url returns 403. An alternative which does not need 403 tests for now might look like this:
But this could also break any moment so it might be better to do 403 tests somehow. If we only talk about loudnessDb for now: |
Is this app going to be updated because it's my lifeline I'm to committed to it to switch |
@finn-524 Nobody knows. Maybe it is dead. Currently we have to wait for @z-huang to become active again. Could be tomorrow. Could be in years. Could be never. Please do not ask about when or if there will be a new release here. This specific issue was meant for developers to discuss solutions to the problems only. |
Good news: |
This is meant for DEVELOPERS ONLY who want to help or discuss the current problems.
Urgent:
U-1.
Merge Player fixes #1789
U-2.
Improve the caching and fix the saved formats issue
Problem: Change player clients & deobfuscate params with NewPipeExtractor #1774 (comment)
Maybe steps to fix: Change player clients & deobfuscate params with NewPipeExtractor #1774 (comment))
U-3. || Update: fixed in Player fixes #1789
Fix normalization. The current clients do not provide the
loudnessDb
anymore or a wrong/different value. This can lead to not working or inconsistent normalization.Change player clients & deobfuscate params with NewPipeExtractor #1774 (comment)
Change player clients & deobfuscate params with NewPipeExtractor #1774 (comment)
A possible fix to make such metadata consistent might be to make two requests to the
player
endpoint:WEB_REMIX
client (the$fields
parameter could be used)WEB_CREATOR
orIOS
clientNice to have:
N-1. || Update: added in Player fixes #1789
Add back the WEB_REMIX client for premium formats
N-2.
Update the NewPipeExtractor dependency once they merge my PR: [YouTube] Fixes for n param deobfuscation function TeamNewPipe/NewPipeExtractor#1253
N-3. || Update: added in Player fixes #1789
Add some way to detect URLs which return 403 and try with another client
The text was updated successfully, but these errors were encountered: