Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

[Bug] I can't play video #146

Open
And9xx opened this issue Oct 22, 2021 · 29 comments
Open

[Bug] I can't play video #146

And9xx opened this issue Oct 22, 2021 · 29 comments
Labels
good first issue Good for newcomers priority: 1 High Priority (Level 1) status: help wanted Extra attention is needed status: needs triage Yet to be reproduced type: bug Something isn't working

Comments

@And9xx
Copy link

And9xx commented Oct 22, 2021

Video player automatically exits when watching anime.

Current workaround: disabling auto fullscreen and auto vertical.

@And9xx And9xx added status: pending review Yet to be reviewed type: bug Something isn't working labels Oct 22, 2021
@zyrouge
Copy link
Collaborator

zyrouge commented Oct 22, 2021

Can you post a clip of that happening? And also which device/os are you using?

@zyrouge zyrouge added status: waiting for response Waiting for cutomer's response and removed status: pending review Yet to be reviewed labels Oct 22, 2021
@And9xx
Copy link
Author

And9xx commented Oct 22, 2021

km_20211022-1_720p.mp4

Here's the clip sir. And im running on custom rom (Corvus OS)

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 22, 2021

Weird issue, don't know what causes this honestly.

@KyleKun
Copy link

KyleKun commented Oct 22, 2021

I can reproduce it as well, will try to investigate later.

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 22, 2021

I can reproduce it as well, will try to investigate later.

Do you have any steps to reproduce? I tried but cannot seem to reproduce.

@zyrouge zyrouge added good first issue Good for newcomers priority: 1 High Priority (Level 1) status: needs triage Yet to be reproduced and removed status: waiting for response Waiting for cutomer's response labels Oct 22, 2021
@KyleKun
Copy link

KyleKun commented Oct 22, 2021

I can reproduce it as well, will try to investigate later.

Do you have any steps to reproduce? I tried but cannot seem to reproduce.

It seems to be related to Force Landscape option in settings, it happens only when it is enable.

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 22, 2021

I can reproduce it as well, will try to investigate later.

Do you have any steps to reproduce? I tried but cannot seem to reproduce.

It seems to be related to Force Landscape option in settings, it happens only when it is enable.

Huh? I've already have it enabled and seems to work. I'll try to repro it somehow.

@KyleKun
Copy link

KyleKun commented Oct 22, 2021

I can reproduce it as well, will try to investigate later.

Do you have any steps to reproduce? I tried but cannot seem to reproduce.

It seems to be related to Force Landscape option in settings, it happens only when it is enable.

Huh? I've already have it enable and seems to work. I'll try to repro it somehow.

The only part I can think of that may be causing this is inside showSelectSources() in watch_page

if (value is extensions.EpisodeSource) {
      final int index = sources!.indexOf(value);
      if (index >= 0) {
        setPlayer(index);
      }
    } else if (currentIndex == null) {
      pop();
}

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 22, 2021

I can reproduce it as well, will try to investigate later.

Do you have any steps to reproduce? I tried but cannot seem to reproduce.

It seems to be related to Force Landscape option in settings, it happens only when it is enable.

Huh? I've already have it enable and seems to work. I'll try to repro it somehow.

The only part I can think of that may be causing this is inside showSelectSources() in watch_page

if (value is extensions.EpisodeSource) {
      final int index = sources!.indexOf(value);
      if (index >= 0) {
        setPlayer(index);
      }
    } else if (currentIndex == null) {
      pop();
}

I can reproduce it as well, will try to investigate later.

Do you have any steps to reproduce? I tried but cannot seem to reproduce.

It seems to be related to Force Landscape option in settings, it happens only when it is enable.

Huh? I've already have it enable and seems to work. I'll try to repro it somehow.

The only part I can think of that may be causing this is inside showSelectSources() in watch_page

if (value is extensions.EpisodeSource) {
      final int index = sources!.indexOf(value);
      if (index >= 0) {
        setPlayer(index);
      }
    } else if (currentIndex == null) {
      pop();
}

Are you able to reproduce it consistently?

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 22, 2021

I could easily mock it, if that's the case, will try tomorrow.

@KyleKun
Copy link

KyleKun commented Oct 22, 2021

I can reproduce it as well, will try to investigate later.

Do you have any steps to reproduce? I tried but cannot seem to reproduce.

It seems to be related to Force Landscape option in settings, it happens only when it is enable.

Huh? I've already have it enable and seems to work. I'll try to repro it somehow.

The only part I can think of that may be causing this is inside showSelectSources() in watch_page

if (value is extensions.EpisodeSource) {
      final int index = sources!.indexOf(value);
      if (index >= 0) {
        setPlayer(index);
      }
    } else if (currentIndex == null) {
      pop();
}

I can reproduce it as well, will try to investigate later.

Do you have any steps to reproduce? I tried but cannot seem to reproduce.

It seems to be related to Force Landscape option in settings, it happens only when it is enable.

Huh? I've already have it enable and seems to work. I'll try to repro it somehow.

The only part I can think of that may be causing this is inside showSelectSources() in watch_page

if (value is extensions.EpisodeSource) {
      final int index = sources!.indexOf(value);
      if (index >= 0) {
        setPlayer(index);
      }
    } else if (currentIndex == null) {
      pop();
}

Are you able to reproduce it consistently?

Yes, it happens every time.

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 22, 2021

I can reproduce it as well, will try to investigate later.

Do you have any steps to reproduce? I tried but cannot seem to reproduce.

It seems to be related to Force Landscape option in settings, it happens only when it is enable.

Huh? I've already have it enable and seems to work. I'll try to repro it somehow.

The only part I can think of that may be causing this is inside showSelectSources() in watch_page

if (value is extensions.EpisodeSource) {
      final int index = sources!.indexOf(value);
      if (index >= 0) {
        setPlayer(index);
      }
    } else if (currentIndex == null) {
      pop();
}

I can reproduce it as well, will try to investigate later.

Do you have any steps to reproduce? I tried but cannot seem to reproduce.

It seems to be related to Force Landscape option in settings, it happens only when it is enable.

Huh? I've already have it enable and seems to work. I'll try to repro it somehow.

The only part I can think of that may be causing this is inside showSelectSources() in watch_page

if (value is extensions.EpisodeSource) {
      final int index = sources!.indexOf(value);
      if (index >= 0) {
        setPlayer(index);
      }
    } else if (currentIndex == null) {
      pop();
}

Are you able to reproduce it consistently?

Yes, it happens every time.

Are you in debug mode? I still don't know if that causes it. The dialog should appear even if there is no sources and it's cannot be dismissed until something is selected. Also it doesn't seem to even switch to watch page completely.

@KyleKun
Copy link

KyleKun commented Oct 22, 2021

I can reproduce it as well, will try to investigate later.

Do you have any steps to reproduce? I tried but cannot seem to reproduce.

It seems to be related to Force Landscape option in settings, it happens only when it is enable.

Huh? I've already have it enable and seems to work. I'll try to repro it somehow.

The only part I can think of that may be causing this is inside showSelectSources() in watch_page

if (value is extensions.EpisodeSource) {
      final int index = sources!.indexOf(value);
      if (index >= 0) {
        setPlayer(index);
      }
    } else if (currentIndex == null) {
      pop();
}

I can reproduce it as well, will try to investigate later.

Do you have any steps to reproduce? I tried but cannot seem to reproduce.

It seems to be related to Force Landscape option in settings, it happens only when it is enable.

Huh? I've already have it enable and seems to work. I'll try to repro it somehow.

The only part I can think of that may be causing this is inside showSelectSources() in watch_page

if (value is extensions.EpisodeSource) {
      final int index = sources!.indexOf(value);
      if (index >= 0) {
        setPlayer(index);
      }
    } else if (currentIndex == null) {
      pop();
}

Are you able to reproduce it consistently?

Yes, it happens every time.

Are you in debug mode? I still don't know if that causes it. The dialog should appear even if there is no sources and it's cannot be dismissed until something is selected. Also it doesn't seem to even switch to watch page completely.

Nope, I just checked in release apk. And yes, it seems that the sources dialog is shown and then the page is popped, before switching to watch page completely.

@JellyJones
Copy link

Happens on windows too if start fullscreen is enabled as well.

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 23, 2021

Happens on windows too if start fullscreen is enabled as well.

Do you have any specific repro steps? I've tried enough but wasn't able to reproduce.

@JellyJones
Copy link

I just downloaded and installed fresh. Tried to play a video, and it would autoclose the video in a similar fashion to the android video. Disabled the Auto Anime Fullscreen option and it works fine. I can manually enter fullscreen perfectly fine.

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 23, 2021

I just downloaded and installed fresh. Tried to play a video, and it would autoclose the video in a similar fashion to the android video. Disabled the Auto Anime Fullscreen option and it works fine. I can manually enter fullscreen perfectly fine.

Can you send the logs from %TEMP%/yukino_app (just paste this in the explorer path) and send the log file with the latest date?

@JellyJones
Copy link

debug 23-10-2021.log

@JellyJones
Copy link

Re-enabling causes it to work perfectly. Perhaps its something to do with how its initialized on first install?

@KyleKun
Copy link

KyleKun commented Oct 23, 2021

Re-enabling causes it to work perfectly. Perhaps its something to do with how its initialized on first install?

On windows only, right? Here on Android this keeps happening...

Edit: now it's working on android here too, what? Lmao

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 23, 2021

Seems weird, the log says there was error when setState was called but I assumed that's because the widget was already removed from the tree, so something should have happened before it then.

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 23, 2021

Re-enabling causes it to work perfectly. Perhaps its something to do with how its initialized on first install?

On windows only, right? Here on Android this keeps happening...

Edit: now it's working on android here too, what? Lmao

So re-enabling fixed it? That's so weird.

@KyleKun
Copy link

KyleKun commented Oct 23, 2021

Seems weird, the log says there was error when setState was called but I assumed that's because the widget was already removed from the tree, so something should have happened before it then.

Maybe we can solve this wrapping the setState with Widgets.instance!.addPostFrameCallback()

@KyleKun
Copy link

KyleKun commented Oct 23, 2021

Re-enabling causes it to work perfectly. Perhaps its something to do with how its initialized on first install?

On windows only, right? Here on Android this keeps happening...

Edit: now it's working on android here too, what? Lmao

So re-enabling fixed it? That's so weird.

Yes and no, it did work on the emulator but on the latest release apk it keeps happening

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 23, 2021

Seems weird, the log says there was error when setState was called but I assumed that's because the widget was already removed from the tree, so something should have happened before it then.

Maybe we can solve this wrapping the setState with Widgets.instance!.addPostFrameCallback()

I think we should wrap it in a if (mounted) {} instead, it would say if the widget is still being used. Oh yeah we must try that.

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 23, 2021

Also, why does it only occur only the first time but doesn't happen after re-enabling? 🤔 So it shouldn't be relevant to it imo.

@KyleKun
Copy link

KyleKun commented Oct 23, 2021

Also, why does it only occur only the first time but doesn't happen after re-enabling? 🤔 So it shouldn't be relevant to it imo.

Agreed, I couldn't find any clues so far...

@zyrouge
Copy link
Collaborator

zyrouge commented Oct 26, 2021

Are you still facing this issue?

@zyrouge zyrouge added the status: help wanted Extra attention is needed label Nov 2, 2021
@And9xx
Copy link
Author

And9xx commented Nov 5, 2021

still facing the issue when force auto-landscape is enabled

@zyrouge zyrouge pinned this issue Nov 14, 2021
@zyrouge zyrouge unpinned this issue Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers priority: 1 High Priority (Level 1) status: help wanted Extra attention is needed status: needs triage Yet to be reproduced type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants