-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar visibility #1627
Calendar visibility #1627
Conversation
Do you think this should be done with a CSS class? |
It could, but since it's a single style, I'm not sure it's worth the extra code in the CSS file :) |
Deferring to @okuryu then. |
I think it doesn't need to have any CSS class for this. @jafl Could you provide an example that causes problems with |
Here is an example: http://jafl.github.io/yui-modules/datetime/ Click the date field under "Date & Time Popup". Then click elsewhere. In the debugger, you can see that the overlay container has the class "yui3-inputpopup-hidden" which sets visibility:hidden, but the calendar is still visible, because "yui3-calendar-content" has visibility:visible explicitly set. My patch modifies that to visibility:inherit, so "yui3-calendar-content" doesn't interfere with parent settings. |
Thanks for the great example! It looks that not only just the |
My pull request covers both. I patched both _afterDateChange() and _rerenderCalendarPane(). |
Aha, thanks. I could confirm that it works. Looks good to me. |
Merged into |
Fix calendar to use visibility:inherit instead of visibility:visible, for compatibility with overlays.