[ie/thisoldhouse] Add login support #8561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The site apparently uses session cookies now, so a credentialed login method was needed. And per the linked issue, the extractor also wasn't always resolving the Zype URL when the video required auth (the auth token is granted/passed in the query of the resolved URL), so that was fixed also
Closes #8257
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 53ea4f8
Summary
🔐🛠️🧹
Enhance
thisoldhouse.py
extractor with login and error handling features. Fix and clean up tests. Refactor video extraction code.Walkthrough
_perform_login
, link, link)urljoin
,urlparse
,compat_parse_qs
,ExtractorError
, andexpected_status
fromutils
module (link)_NETRC_MACHINE
attribute tothisoldhouse
to enable netrc credentials (link)_perform_login
method that performs multiple requests and form submissions to log in to the site (link)_real_extract
and call_perform_login
if needed (link)r'<iframe[^>]+src="([^"]+zype\.com/([^/]+)/embed[^"]*)"'
) (link)Location
header (link)ExtractorError
if login fails or Zype URL is invalid (link)how-to-build-a-storage-bench
video to/watch/how-to-build-a-storage-bench/
(link)how-to-build-a-raised-vegetable-garden
video to/watch/how-to-build-a-raised-vegetable-garden/
and add comment that it is only matching due to geo-restriction (link)how-to-build-a-picnic-table
video and add comment that it is no longer available (link)