-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/Dropbox] Fix extractor #7926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since dropbox updated their share links around July this year, I had to make an update it to keep using this extractor. This new regex handles old and new link formats.
Add a test for each of the new URL formats |
bashonly
added
site-bug
Issue with a specific website
pending-fixes
PR has had changes requested
labels
Aug 21, 2023
bashonly
requested changes
Aug 21, 2023
Co-authored-by: bashonly <[email protected]>
11 tasks
@bashonly & @nathantouze this PR is partially fix the extractor because it still generate an error "mountComponent" #7005 |
DoubiTe
approved these changes
Aug 21, 2023
Extraction should be working now, you should be able to add/update tests |
DoubiTe
approved these changes
Aug 22, 2023
bashonly
approved these changes
Aug 22, 2023
bashonly
added
pending-review
PR needs a review
and removed
pending-fixes
PR has had changes requested
labels
Aug 22, 2023
pukkandan
requested changes
Aug 26, 2023
Co-authored-by: pukkandan <[email protected]>
bashonly
reviewed
Aug 28, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#7005, Closes yt-dlp#7696 Authored by: nathantouze, bashonly, denhotte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since dropbox updated their share links around July this year, I had to make an update it to keep using this extractor.
This new regex handles old and new link formats.
Dropbox changed their link format earlier this year. The exctractor weren't working anymore with new links. A change was mandatory to keep using the software.
Old formats:
https://www.dropbox.com/s/<id>/*
https://www.dropbox.com/sh/<id>/*
Added formats:
https://www.dropbox.com/e/scl/fi/<id>/*
https://www.dropbox.com/scl/fi/<id>/*
(EDIT: Also fixed extraction --@bashonly)
Closes #7005, Closes #7696
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at e43c809
Summary
📁🔗🎥
Improve Dropbox extractor to support more link formats. Update
_VALID_URL
inyt_dlp/extractor/dropbox.py
to match them.Walkthrough
_VALID_URL
regex pattern to support more Dropbox link formats (link)