[extractor/twitter] fix extraction through rest api on links to retweet id #6422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et id a retweet has its own id. with recent lack of quality assurance, the "[someone] liked your retweet" notifications are now pointing to the id of the retweet, instead of id of the post. with this change, extractor looks for the retweeted tweet, which is contained inside the response under "retweeted_tweet" key.
pukkandan
reviewed
Mar 4, 2023
pukkandan
approved these changes
Mar 4, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: selfisekai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
a retweet has its own id. with recent lack of quality assurance, the "[someone] liked your retweet" notifications are now pointing to the id of the retweet, instead of id of the post.
with this change, extractor looks for the retweeted tweet, which is contained inside the response under "retweeted_tweet" key.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?