-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/twitch] Skip errors in GQL response #6318
Conversation
Co-authored-by: pukkandan <[email protected]>
With this patch applied, stream titles will randomly fail to be fetched. Which VOD fails to title fetch varies on every run of the
My
|
Looking at the extractor and error more closely, the problem was that some _OPERATION_HASHES were not up to date I've updated these hashes and updated some tests This shoud fix the titles @garoto |
Tested a bunch of VODs and it seems to be fixed indeed. Thank you! |
Authored by: elyse0 Closes yt-dlp#6308
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This PR fixes the problem where Twitch's GQL API sometimes returns an error before the actual data, breaking the extractor that assumed the video data would be at index 0.
Full json response: https://gist.github.com/elyse0/3b1679b6a0b8d7aa8112f75c1eb52403
Trimmed json
Fixes #6308
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?