[extractor/tv4] Fix tv4 extraction

[TxI5]

changed json api url

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

TV4 has changed their api domain. This changes the url for json metadata extraction

Fixes #5535

Template

Before submitting a pull request make sure you have:

• At least skimmed through contributing guidelines including yt-dlp coding conventions
• Searched the bugtracker for similar pull requests
• Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

• I am the original author of this code and I am willing to release it under Unlicense
• I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

• Fix or improvement to an extractor (Make sure to add/update tests)
• New extractor (Piracy websites will not be accepted)
• Core bug fix/improvement
• New feature (It is strongly recommended to open an issue first)

[TxI5]

Closes #5535

[bashonly]

use f-strings for both API URLs for consistency / readability

Suggested change

	'https://playback2.a2d.tv/asset/%s' % video_id,
	f'https://playback2.a2d.tv/asset/{video_id}',

[dirkf]

Definitely make them consistent, but if it's done using f-strings yt-dl will just have to change it to any of the other myriad string syntaxes (I know that's our burden).

Maybe s/t like this:

    def _call_api(self, endpoint, video_id, query=None, **kwargs):
        return self._download_json(
            '/'.join(('https://playback2.a2d.tv', endpoint, video_id)),
            video_id, endpoint.join(('Downloading video ', ' JSON')),
            query=update_url_query({
                'service': 'tv4',
                'device': 'browser',
                'protocol': 'hls,dash',
            }, query), **kwargs)
...
        info = self._call_api('asset', video_id, query={
                'drm': 'widevine',
            })['metadata']
...
        manifest_url = self._call_api('play', video_id, expected_status=401)
        # don't crash during error handling
        err = traverse_obj(manifest_url, 'errorCode')
...
        # then as in https://github.com/yt-dlp/yt-dlp/pull/5649#issuecomment-1337847672 below

Related to the geo-restriction handling, in the class:

    # XFF is not effective
    _GEO_BYPASS = False

and perhaps specialise the msg for raise_geo_restricted() if, as I believe, a logged-in user can access the site from outside SE/EU:

                self.raise_geo_restricted(
                    'This video is not available from your location due to geo restriction, or not being authenticated.',
                    countries=['SE'])

[pukkandan]

Definitely make them consistent, but if it's done using f-strings yt-dl will just have to change it to any of the other myriad string syntaxes (I know that's our burden).

Sorry, but if we discourage the use of newer Python features, then there was no point in deprecating older versions. In most cases (including here) fstrings simply read much better than the alternatives.

You could encourage OP to make PR against youtube-dl and get it merged there first - which would reverse our responsibilities; i.e. the burden of code review will then mainly fall on you, and the burden of porting (dealing with deprecated imports/functions) on me

[dirkf]

Fair point, but in this case it is at least possible to have just the one instance, and also avoid replicating the base API URL.

[pukkandan]

oh, I wasn't commenting on the whole thing, just on the quoted part. Having a _call_api does look good

[dirkf]

And in any case, https://gist.github.com/dirkf/26c1dc0e0f29e2663c8cfd58f932aca6.

[bashonly]

Suggested change

	'https://playback2.a2d.tv/play/' + video_id,
	f'https://playback2.a2d.tv/play/{video_id}',

[bashonly]

Although not related to the original issue, the geo-restriction processing could be also improved. XFF doesn't work for this site.

I've applied some yt-dl test code that could be adapted:

This is a good idea, since it seems like all tv4 content is geo-restricted now. But the diff posted above conflates the asset endpoint with the play endpoint.

A working version could look like this (using this PR's initial commit as baseline for the diff):

-        manifest_url = self._download_json(
-            'https://playback2.a2d.tv/play/' + video_id,
-            video_id, query={
+        manifest_info = self._download_json(
+            f'https://playback2.a2d.tv/play/{video_id}',
+            video_id, 'Downloading manifest info JSON', query={
                 'service': 'tv4',
                 'device': 'browser',
                 'protocol': 'hls',
-            })['playbackItem']['manifestUrl']
+            }, expected_status=401)
+        err = manifest_info.get('errorCode')
+        if err:
+            msg = manifest_info.get('message') or err
+            if 'GEO_LOCATION' in err:
+                self.raise_geo_restricted(msg, countries=['SE'])
+            raise ExtractorError(f'HTTP Error 401: Unauthorized; {msg}', video_id=video_id)
+
+        manifest_url = manifest_info['playbackItem']['manifestUrl']
+

[pukkandan]

Does this still work? Pls update tests

[aejdl]

This step (manifest download) requires geo-verification outside Sweden. The following update would solve that part:

manifest_url = self._download_json(
    'https://playback2.a2d.tv/play/%s' % video_id,
    video_id, query={
        'service': 'tv4',
        'device': 'browser',
        'browser': 'GoogleChrome',
        'protocol': 'hls,dash',
        'drm': 'widevine',
        'capabilities': 'live-drm-adstitch-2,expired_assets',
    },
    headers=self.geo_verification_headers(),
)['playbackItem']['manifestUrl']

[pukkandan]

Why?

[bashonly]

per dirkf's comment here #5649 (comment) that xff is futile

[pukkandan]

Then why r we passing go verification headers? Am I misunderstanding something?

[bashonly]

_GEO_BYPASS is for --xff, which has no effect
geo_verification_headers() are for --geo-verification-proxy, which does work