-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/eggs] Add extractors #11904
[ie/eggs] Add extractors #11904
Conversation
Having a quick look at the app, there exists a JSON API
Headers are
I, personally, would vastly prefer using the api instead of relying on regexing the webpage. |
Ah, I hadn’t looked into the Android app. Thank you for the hint. It seems that for retrieving the API, in addition to at least the Also, it appears that on an artist’s page or a single’s page, some tracks may be YouTube links. In that case, I think the appropriate approach would be to call an existing YouTubeIE or similar to handle the processing. If so, is there a way to save the output in m4a or mp3 formats? |
imo. that's fine. Mabe include the
Not from the extractor side. The extractor should just return a url result to YoutubeIE. The user can then use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reworked the extractors a bit
Co-authored-by: bashonly <[email protected]>
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This PR adds support for extracting audio from the music platform Eggs.
For a single page, it extracts one audio file.
For an artist page, it downloads all audio files from the list.
It didn't seem like there were any basic JSON or API endpoints available on the site.
I'm still a beginner, so please go easy on me.
Fixes #11843
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?