experimental xrender - unredir crash, the 2nd #239
Comments
|
thanks. this is related to getting a ShapeNotify in the same cycle the window is unmap, i haven't found the cause yet. if you can reproduce this with a debug build of compton, it would be helpful. |
|
Yeah, I can reliably reproduce it simply by doing alt + tabbing out of vkquake. |
|
@aufkrawall can you attach the dump and binary from a debug build? but i think i know where the problem is now, will fix once i get back to my computer. |
|
Ah, yeah. I didn't enable debug build in meson. |
Can you create a debug build? |
Of course, stay tuned. |
|
Same content as above, but with debug build: |
Signed-off-by: Yuxuan Shui <[email protected]>
Previously all image stale flags are ignored when processing an unmapped window. If a window gains a shadow during its fading out transition, the shadow flag will be set, but shadow won't actually be generated, causing a NULL pointer dereference during render. Fixes #239 Signed-off-by: Yuxuan Shui <[email protected]>
|
@aufkrawall should've been fixed, can you try the latest |
|
@yshui Haven't tested with the same AMD GPU system, but on my Intel notebook it still crashes. |
|
@yshui <https://github.com/yshui> Haven't tested with the same AMD GPU
system, but on my Intel notebook it still crashes.
that's odd, i cannot reproduce it anymore. could be a different crash?
can you attach the newer log/dump? thanks.
… |
|
Here we go again: |
|
i found the cause. it's because the window is unmapped the same cycle the screen is redirected, so it didn't get a chance to acquire the pixmap solving this one will be a bit trickier |
If a window is unmapped during the draw_callback re-run when the screen is just redirected, that window won't get a chance to acquire a pixmap. If fading is enabled, the compositor will try to render that window and crash. Signed-off-by: Yuxuan Shui <[email protected]>
|
@aufkrawall hopefully it's fixed now. |
|
@yshui Yep, issue's gone here. |
The compositor crashes when a window does: has shadow -> no shadow -> has shadow This is because when the shadow is turned off, the shadow image is not freed, and this is catched by a later assertion. Signed-off-by: Yuxuan Shui <[email protected]>
Hello yhsui,
as mentioned there, this issue is back since commit eecee13
#189
Attached is a debug log, crash dump and compton binary.
compton.zip
The text was updated successfully, but these errors were encountered: