Skip to content

Commit

Permalink
win: fix EWMH fullscreen detection
Browse files Browse the repository at this point in the history
In `win_update_prop_fullscreen`, if _NET_WM_STATE is empty we exited
early and forgot to set fullscreen to false.

Fixes #1216

Signed-off-by: Yuxuan Shui <[email protected]>
  • Loading branch information
yshui committed Mar 11, 2024
1 parent 040cc10 commit 6de56c6
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/win.c
Original file line number Diff line number Diff line change
Expand Up @@ -1035,10 +1035,6 @@ win_update_prop_shadow(struct x_connection *c, struct atom *atoms, struct manage
bool win_update_prop_fullscreen(struct x_connection *c, const struct atom *atoms,
struct managed_win *w) {
auto prop = x_get_prop(c, w->client_win, atoms->a_NET_WM_STATE, 12, XCB_ATOM_ATOM, 0);
if (!prop.nitems) {
return false;
}

bool is_fullscreen = false;
for (uint32_t i = 0; i < prop.nitems; i++) {
if (prop.atom[i] == atoms->a_NET_WM_STATE_FULLSCREEN) {
Expand Down

0 comments on commit 6de56c6

Please sign in to comment.