Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLCA wrong regularization update #14

Closed
yoyolicoris opened this issue Mar 12, 2021 · 0 comments · Fixed by #15
Closed

PLCA wrong regularization update #14

yoyolicoris opened this issue Mar 12, 2021 · 0 comments · Fixed by #15
Assignees
@yoyolicoris
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@yoyolicoris
Copy link
Owner

https://github.com/yoyololicon/pytorch-NMF/blob/dce05b2d40262950ab45e48ff30a7ca79589cf86/torchnmf/plca.py#L275

These 6 lines may cause problem when alpha != 1 but params does not require grad and should not be modified.
@yoyolicoris yoyolicoris self-assigned this Mar 12, 2021
@yoyolicoris yoyolicoris added bug Something isn't working invalid This doesn't seem right labels Mar 12, 2021
@yoyolicoris yoyolicoris pinned this issue Mar 12, 2021
@yoyolicoris yoyolicoris mentioned this issue Mar 12, 2021
Merged
@yoyolicoris yoyolicoris unpinned this issue Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoyolicoris yoyolicoris

Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: plca update logic yoyolicoris/pytorch-NMF
1 participant
@yoyolicoris