Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audioop missing #6

Closed
lucas42 opened this issue Oct 14, 2024 · 2 comments
Closed

audioop missing #6

lucas42 opened this issue Oct 14, 2024 · 2 comments

Comments

@lucas42
Copy link
Contributor

lucas42 commented Oct 14, 2024

This repository doesn't include code for audioop, despite it being in the PEP 594 list.
Is this because audioop-lts exists as an alternative?
It'd be useful to have an explanation somewhere in this repository, especially because 2 of the libraries here depend on audioop (See #5 )

@youknowone
Copy link
Owner

youknowone commented Oct 15, 2024

I decided to start by including only pure Python libraries. It might not be explicit enough, but I tried to leave the following information in README:

If your project depends on a module that has been removed from the standard library, here is the redistribution of the deprecated modules in pure Python.

This is not a strict policy, but mainly due to my lack of enthusiasm for spending effort. audioop-lts didn't affect the decision because I included nntplib even though there was already an alternative library. Any patch about missing libraries will be welcome. (probably I'd better to write this in README)
For this case, if audioop-lts already exists and as long as it is compatible with legacy audioop, adding it as a dependency and updating aifc and sunau to using it will be good too.


This is not about the issue, but you seem to know better about python legacy libraries. Please feel free to ask maintenance permissions if are interested in.

@lucas42
Copy link
Contributor Author

lucas42 commented Oct 15, 2024

Thanks for the clarification! I hadn't realised the distinction between pure python packages and other types.
(Though I'd never dived into the python codebase itself, until I was hit by this PEP 594 change in the release of 3.13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants