Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.70 #1996

Closed
wants to merge 2 commits into from
Closed

Rust 1.70 #1996

wants to merge 2 commits into from

Conversation

yihuaf
Copy link
Collaborator

@yihuaf yihuaf commented Jun 1, 2023

1.70 is released.

Note the fix to the new lint, ///! is not a valid comment. //! is valid. Now clippy complains it. Reference: https://doc.rust-lang.org/reference/comments.html

yihuaf added 2 commits June 1, 2023 12:08
@yihuaf yihuaf requested review from utam0k, YJDoc2 and a team June 1, 2023 19:10
@yihuaf yihuaf self-assigned this Jun 1, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1996 (35f49e1) into main (cb75d26) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1996   +/-   ##
=======================================
  Coverage   65.28%   65.28%           
=======================================
  Files         129      129           
  Lines       14784    14784           
=======================================
  Hits         9651     9651           
  Misses       5133     5133           

@yihuaf
Copy link
Collaborator Author

yihuaf commented Jun 2, 2023

Pending #1973 to fix the integration test

@yihuaf yihuaf closed this Jun 4, 2023
@yihuaf yihuaf deleted the yihuaf/rust-1.70 branch June 4, 2023 01:30
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jun 5, 2023

bookkeeping : done in #1973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants