Refactor the lifecycle test #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1868 +/- ##
=======================================
Coverage 68.89% 68.89%
=======================================
Files 122 122
Lines 13717 13717
=======================================
+ Hits 9450 9451 +1
+ Misses 4267 4266 -1 |
YJDoc2
requested changes
May 5, 2023
tests/rust-integration-tests/integration_test/src/tests/lifecycle/container_create.rs
Outdated
Show resolved
Hide resolved
tests/rust-integration-tests/integration_test/src/tests/lifecycle/container_create.rs
Outdated
Show resolved
Hide resolved
yihuaf
force-pushed
the
yihuaf/refactor-tests
branch
from
68eb0c3 to
2843bf9
Compare
|
@YJDoc2 PTAL |
Signed-off-by: yihuaf <[email protected]>
yihuaf
force-pushed
the
yihuaf/refactor-tests
branch
from
2843bf9 to
148f194
Compare
Signed-off-by: yihuaf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously discussed in #1827 , the
TestResultis meant to be used in the test cases and not utility functions. Before this PR, the lifecycle test calls other tests usingTestResultwhich is not inline with our intention. This PR fix this by refactoring all tests to not call other tests in test cases.