Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and unify the use of tempdir and tempfile #1883

Closed
4 tasks done
yihuaf opened this issue May 6, 2023 · 1 comment
Closed
4 tasks done

Clean up and unify the use of tempdir and tempfile #1883

yihuaf opened this issue May 6, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@yihuaf
Copy link
Collaborator

yihuaf commented May 6, 2023

Currently, we are rolling our own implementation of tempdir and duplicated the code in multiple places. In addition, I don't like the struct implements using option<path> and the path() has a expect() which can panic if called after remove. The proposed solution is to use tempfile crate. https://github.com/Stebalien/tempfile

@yihuaf yihuaf self-assigned this May 6, 2023
@yihuaf yihuaf added the enhancement New feature or request label May 6, 2023
@utam0k
Copy link
Member

utam0k commented May 6, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants