Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec.root.path is not correctly handled #152

Closed
yihuaf opened this issue Jul 21, 2021 · 1 comment · Fixed by #153
Closed

spec.root.path is not correctly handled #152

yihuaf opened this issue Jul 21, 2021 · 1 comment · Fixed by #153
Assignees
@yihuaf

Comments

@yihuaf
Copy link
Collaborator

yihuaf commented Jul 21, 2021

Currently, the spec.root.fs is not correctly handled. When init_builder calls load_and_safeguard_spec, the copied version of the spec.json doesn't contain the change to canonicalize the rootfs path. As a result, when youki exec tries to load the safeguarded spec in tenent_builder, the spec.root.path can be incorrect missing the bundle path. As a result, currently, youki exec is also broken.

There are two solutions. One is to save the canonicalized rootfs path with bundle path as part of the spec when safeguard the spec into the /run/youki/<id>. The other option is to take care to canonicalize the path with bundle path again when loading the path in tenent_builder.
@yihuaf yihuaf mentioned this issue Jul 21, 2021
Merged
@yihuaf
Copy link
Collaborator Author

yihuaf commented Jul 21, 2021

/assign

@YJDoc2 YJDoc2 mentioned this issue Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yihuaf yihuaf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly handle the rootfs path with bundle yihuaf/youki
1 participant
@yihuaf