Implement merge elements in Tree.Edit #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerwins
force-pushed
the
tree-merge-split
branch
from
9a94574 to
3855dc4
Compare
hackerwins
force-pushed
the
tree-merge-split
branch
from
3855dc4 to
38caea6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
=======================================
Coverage ? 48.96%
=======================================
Files ? 69
Lines ? 10090
Branches ? 0
=======================================
Hits ? 4941
Misses ? 4631
Partials ? 518
☔ View full report in Codecov by Sentry. |
hackerwins
force-pushed
the
tree-merge-split
branch
from
8a9db21 to
0afdc05
Compare
hackerwins
force-pushed
the
tree-merge-split
branch
from
0afdc05 to
9d57453
Compare
hackerwins
added a commit
that referenced
this pull request
Nov 3, 2023
In a text-based editor, when you have a selection that spans two paragraphs, if you press the delete key, removes the second paragraph and merges its children into the first paragraph. For example: Before: `<p>a|b</p><p>c|d</p>` After: `<p>ad</p>` This commit implements the merge to Tree.Edit.
hackerwins
added a commit
that referenced
this pull request
Nov 3, 2023
In a text-based editor, when you have a selection that spans two paragraphs, if you press the delete key, removes the second paragraph and merges its children into the first paragraph. For example: Before: `<p>a|b</p><p>c|d</p>` After: `<p>ad</p>` This commit implements the merge to Tree.Edit.
hackerwins
added a commit
that referenced
this pull request
Nov 4, 2023
In a text-based editor, when you have a selection that spans two paragraphs, if you press the delete key, removes the second paragraph and merges its children into the first paragraph. For example: Before: `<p>a|b</p><p>c|d</p>` After: `<p>ad</p>` This commit implements the merge to Tree.Edit.
hackerwins
added a commit
that referenced
this pull request
Nov 4, 2023
In a text-based editor, when you have a selection that spans two paragraphs, if you press the delete key, removes the second paragraph and merges its children into the first paragraph. For example: Before: `<p>a|b</p><p>c|d</p>` After: `<p>ad</p>` This commit implements the merge to Tree.Edit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implement merge feature in
Tree.EditIn a text-based editor, when you have a selection that spans two paragraphs, if you press the delete key, removes the second paragraph and merges its children into the first paragraph.
For example:
<p>a|b</p><p>c|d</p><p>ad</p>This commit implements the merge to Tree.Edit.
Which issue(s) this PR fixes:
Address #662
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: